Fixed issue 430 - Change downloaded CSV filename to a meaningful name… #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Example: Anyway-accidents-from-2012-01-31-to-2015-10-12.csv
| @@ -139,7 +139,7 @@ def markers(): | |||
| if request.values.get('format') == 'csv': | |||
| return Response(generate_csv(accidents), headers={ | |||
| "Content-Type": "text/csv", | |||
| "Content-Disposition": 'attachment; filename="data.csv"' | |||
| "Content-Disposition": 'attachment; filename="Anyway-accidents-from-'+kwargs['start_date'].strftime('%Y-%m-%d')+'-to-'+kwargs['end_date'].strftime('%Y-%m-%d')+'.csv"' | |||
There was a problem hiding this comment.
It's not a big deal but in this case I would
- extract the format specifier
%Y-%m-%dto a variable - use
formatrather than concatenating strings
Also, you should use a # before the issue number in the commit message, so GitHub will know to automatically associate it (and also close it if you say "fixed" in the message).
|
@kilaka please fix and I'll merge. |
danielhers
force-pushed
the
dev
branch
2 times, most recently
from
a6f1b00 to
73754d4
Compare
omerxx
added a commit
to omerxx/anyway
that referenced
this pull request
Nov 20, 2015
…hange downloaded csv name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #430 - Change downloaded CSV filename to a meaningful name. Example:
Anyway-accidents-from-2012-01-31-to-2015-10-12.csv