Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 new tests and tests documentation #660

Merged
merged 1 commit into from
Feb 8, 2017

Conversation

ChaosPredictor
Copy link

@ChaosPredictor ChaosPredictor commented Jan 30, 2017

2 new tests: /clusters and /markers/int:marker_id GET requests, documentation test file

Copy link
Collaborator

@danielhers danielhers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should test /clusters with some data returned. Also, /markers is done but should be improved by asserting the properties of returned markers, e.g., that when asking specific severity, the returned markers are of the correct severity.

#print(rv.data)
resp = json.loads(rv.data)
self.assertIn('clusters', resp)
self.assertEqual(len(resp['clusters']), 0)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to zoom out to get any clusters, no?

Copy link
Author

@ChaosPredictor ChaosPredictor Feb 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried zoom out but I think there is no clusters data at all

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, let's figure this out for the next PR

@danielhers danielhers merged commit e7cf833 into data-for-change:dev Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants