Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing with auth0 #2

Merged
merged 3 commits into from
Feb 8, 2021
Merged

Testing with auth0 #2

merged 3 commits into from
Feb 8, 2021

Conversation

mmnoo
Copy link
Contributor

@mmnoo mmnoo commented Feb 7, 2021 •
edited
Loading

  • extend testing library to override its render function to redirect to newly created renderAuthenticated or renderUnauthenticated
  • fix issue where pre-push hooks arent guaranteed

@brianbancroft
Copy link
Contributor

Do you find that the testing slows down when you toss in many providers? I find this to be the case, especially when I include a full redux setup :/

@mmnoo mmnoo merged commit 2029e8e into main Feb 8, 2021
@mmnoo mmnoo deleted the testingWithAuth0 branch February 9, 2021 15:40
@mmnoo
Copy link
Contributor Author

mmnoo commented Feb 9, 2021

Do you find that the testing slows down when you toss in many providers? I find this to be the case, especially when I include a full redux setup :/

I havent noticed yet. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianbancroft brianbancroft brianbancroft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmnoo @brianbancroft