Merge pull request #479 from data-to-insight/Fix-88

Minor fixes
data-to-insight · May 22, 2024 · 5462c46 · 5462c46
2 parents d94cc2d + 40668e3
commit 5462c46
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/cin_validator/rules/cin2022_23/rule_8873Q.py b/cin_validator/rules/cin2022_23/rule_8873Q.py
@@ -74,7 +74,7 @@ def validate(
     )
 
     df_ass_merged = df_ass_merged[
-        (df_ass_merged[AssessmentFactor] == "2B")
+        (df_ass_merged[AssessmentFactor] == "21")
         | (df_ass_merged[AssessmentFactor] == "21 No factors identified")
         | (df_ass_merged[AssessmentFactor].str.contains("21"))
     ]

diff --git a/cin_validator/rules/cin2022_23/rule_8898.py b/cin_validator/rules/cin2022_23/rule_8898.py
@@ -156,7 +156,7 @@ def test_validate():
     # check that the failing locations are contained in a DataFrame having the appropriate columns. These lines do not change.
     assert isinstance(issue_rows, pd.DataFrame)
     assert issue_rows.columns.to_list() == ["ERROR_ID", "ROW_ID"]
-    print(issue_rows)
+
     # Create the dataframe which you expect, based on the fake data you created. It should have two columns.
     # - The first column is ERROR_ID which contains the unique combination that identifies each error instance, which you decided on earlier.
     # - The second column in ROW_ID which contains a list of index positions that belong to each error instance.