Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/general tests #331

Merged
merged 5 commits into from
Aug 23, 2023
Merged

Test/general tests #331

merged 5 commits into from
Aug 23, 2023

Conversation

tab1tha
Copy link
Collaborator

@tab1tha tab1tha commented Feb 9, 2023

Check that the ruleset has the number of rules expected.

Copy link
Contributor

@WillLP-code WillLP-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you get this documented in sphinx format like the rest of the code then it looks good to go!

@tab1tha
Copy link
Collaborator Author

tab1tha commented Feb 9, 2023

Can you get this documented in sphinx format like the rest of the code then it looks good to go!

Sure

@tab1tha
Copy link
Collaborator Author

tab1tha commented Feb 9, 2023

Can you get this documented in sphinx format like the rest of the code then it looks good to go!

Sure

Actually, it is a test function. So it neither has parameters nor does it return anything. @willLPD2I
With the test functions, can we include explanatory documentation only if needed ?

@WillLP-code
Copy link
Contributor

Can you get this documented in sphinx format like the rest of the code then it looks good to go!

Sure

Actually, it is a test function. So it neither has parameters nor does it return anything. @willLPD2I With the test functions, can we include explanatory documentation only if needed ?

Sounds fair! If you could pop something really brief in the docs then?

@tab1tha
Copy link
Collaborator Author

tab1tha commented Aug 23, 2023

When changes from the main branch are brought in, this test now fails because rules 8899Q and 8617 have been removed (#344).
Hence the new total number of tests should be 105 instead of 107.

@tab1tha tab1tha merged commit 4bd5a70 into main Aug 23, 2023
6 checks passed
@tab1tha tab1tha deleted the test/general-tests branch August 23, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants