Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Assessment Factors into separate dataframe to reduce duplication of error rows passed to FE #475

Merged
merged 6 commits into from
May 17, 2024

Conversation

SLornieCYC
Copy link
Contributor

Current

Ingress creates a separate row in the Assessments dataframe for each AssessmentFactors value within a LAchildID-CINdetailsID-AssessmentActualStartDate set. This means that where an assessment has many factors assigned, the assessment is duplicated within the dataset and any in-error assessments are reported multiple times in the FE.

Proposed

Amend ingress to store the assessment factors in a separate dataframe, linked to the parent assessment (and CINdetailsID) via a new internally incremented AssessmentID value. I have ensured that the AssessmentFactors column remains on the Assessments dataframe, but now as a single string containing a list of the factors assigned on the assessment.

The new AssessmentFactorsList dataframe can be used within the relevant validations rules to return the incorrect records, while at the same time being ignored for other validation rules that do not involve assessment factors. This will remove unnecessary duplicate assessment rows from both the validation rules and the FE error lists.

Note: I am not 100% sure how the FE data tables are built and whether some corresponding changes need to be made on that side to handle this change (e.g. do they use the dataframes from ingress or a separate parsing from the uploaded source files).

@WillLP-code WillLP-code added this pull request to the merge queue May 17, 2024
Merged via the queue into main with commit a72b87f May 17, 2024
6 checks passed
@WillLP-code WillLP-code deleted the assessment_factors branch May 17, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants