👷 Update base alpine version to v3.14 #716
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilko77
approved these changes
Nov 23, 2021
hardbyte
force-pushed
the
update-alpine-to-v3.14
branch
3 times, most recently
from
3452682
to
2a5f1a9
Compare
hardbyte
force-pushed
the
update-alpine-to-v3.14
branch
from
2a5f1a9
to
d6a1995
Compare
|
@hardbyte any plans to get this merged in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noted that building the base image wasn't actually reproducible despite our overzealous pinning of requirements... so to make life easier I suggest we continue to pin the FROM docker image but allow alpine to find the consistent set of packages within that.
I've manually built and ran e2e tests via docker-compose.