Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add geometry data type #352

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

ariesdevil
Copy link
Contributor

Add new token GEOMETRY and new data type Geometry.

@everpcpc
Copy link
Member

everpcpc commented Feb 6, 2024

Bindings should also be updated for new type.

@ariesdevil
Copy link
Contributor Author

Bindings should also be updated for new type.↳

Done, PTAL again.

@everpcpc
Copy link
Member

everpcpc commented Feb 6, 2024

error[source-not-allowed]: detected 'git' source not explicitly allowed
    ┌─ /home/runner/work/bendsql/bendsql/Cargo.lock:107:16
    │
107 │ geozero 0.11.0 git+https://github.com/georust/geozero?rev=1d78b36

@ariesdevil
Copy link
Contributor Author

error[source-not-allowed]: detected 'git' source not explicitly allowed
    ┌─ /home/runner/work/bendsql/bendsql/Cargo.lock:107:16
    │
107 │ geozero 0.11.0 git+https://github.com/georust/geozero?rev=1d78b36

I don't know how to fix this...

@everpcpc
Copy link
Member

everpcpc commented Feb 6, 2024

Git dependency is not allowed here. Each dependency should be published on crates.io.

@ariesdevil
Copy link
Contributor Author

https://github.com/georust/geozero

georust/geozero#188 (comment) I asked but no response...

@everpcpc
Copy link
Member

everpcpc commented Feb 6, 2024

Maybe we could fork and publish to a new crate?

@ariesdevil
Copy link
Contributor Author

Maybe we could fork and publish to a new crate?↳

This is a bit strange. GeoRust is an active development community, but I don't quite understand their release strategy.

@everpcpc
Copy link
Member

geozero seems released 0.12.0

@ariesdevil ariesdevil force-pushed the geometry branch 2 times, most recently from 761e2eb to f5e16fb Compare February 28, 2024 08:52
@everpcpc everpcpc merged commit e0da4f8 into databendlabs:main Feb 29, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants