Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow select version() failed #452

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Jul 12, 2024

In PR databendlabs/databend#16031

We support the feature that user can continue login and change the password after the password expires. In this case, the user cannot perform other operations except changing the password. As a result, the SQL select version(), which is automatically sent by BendSQL fails to be executed and exits, causing the user can't change the password. This PR allows select version() to fail and not exit, and user can continue change password.

@everpcpc
Copy link
Member

Maybe we should handle the error for select version under cli instead of driver

@everpcpc everpcpc merged commit b7bbfcf into databendlabs:main Jul 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants