feat: support passive auto discovery #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaneur2020
reviewed
Sep 6, 2024
databend-jdbc/src/main/java/com/databend/jdbc/AbstractDatabendResultSet.java
Outdated
Show resolved
Hide resolved
flaneur2020
reviewed
Sep 6, 2024
| */ | ||
| void tryAutoDiscovery(OkHttpClient client, ClientSettings settings) { | ||
| if (this.autoDiscovery) { | ||
| if (this.driverUri.enableMock()) { |
flaneur2020
reviewed
Sep 6, 2024
| logger.log(Level.WARNING, "Current Query Node do not support auto discovery, close the functionality: " + e.getMessage()); | ||
| this.autoDiscovery = false; | ||
| } catch (Exception e) { | ||
| logger.log(Level.FINE, "Error auto discovery: " + " cause: " + e.getCause() + " message: " + e.getMessage()); |
There was a problem hiding this comment.
first time to find out FINE log level, what's it's normal use case?
(not an issue at all, just curious 👀)
There was a problem hiding this comment.
info level will print problem by default, I think it is similar to DEBUG level on golang
flaneur2020
reviewed
Sep 6, 2024
|
|
||
| public class DatabendNodes implements DatabendNodeRouter { | ||
|
|
||
| private AtomicReference<List<URI>> query_nodes_uris; | ||
| protected final AtomicInteger index; | ||
| // keep track of latest discovery scheduled time | ||
| protected final AtomicReference<Long> lastDiscoveryTime = new AtomicReference<>(0L); | ||
| private static final Logger logger = Logger.getLogger(DatabendNodes.class.getPackage().getName()); | ||
| @Setter | ||
| private boolean debug = false; |
There was a problem hiding this comment.
i guess if there is only one setter, define a setDebug is preferrable than using lomok
flaneur2020
approved these changes
Sep 6, 2024
cdmikechen
pushed a commit
to cdmikechen/databend-jdbc
that referenced
this pull request
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.