Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sqllogic unexpected pass error #12174

Closed
wants to merge 14 commits into from
Closed

fix: sqllogic unexpected pass error #12174

wants to merge 14 commits into from

Conversation

JackTan25
Copy link
Contributor

@JackTan25 JackTan25 commented Jul 24, 2023 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR
risinglightdb/sqllogictest-rs#178
fix at risinglightdb/sqllogictest-rs#187

  • Closes #issue

This change is Reviewable

@vercel
Copy link

vercel bot commented Jul 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
databend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 3, 2023 10:33am

@JackTan25 JackTan25 added the ci-cloud Build docker image for cloud test label Jul 24, 2023
@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-12174-6bc7d0a

note: this image tag is only available for internal use,
please check the internal doc for more details.

@JackTan25 JackTan25 changed the title chore: try get ci-clound fix: sqllogic unexpected pass error Jul 25, 2023
@JackTan25 JackTan25 marked this pull request as ready for review July 25, 2023 03:48
@JackTan25 JackTan25 requested review from xudong963 and Xuanwo and removed request for xudong963 July 25, 2023 03:49
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Jul 25, 2023
@JackTan25
Copy link
Contributor Author

JackTan25 commented Jul 25, 2023 •
edited
Loading

waiting for issues: #12193 , #12192 , #12191, #12205

Xuanwo
Xuanwo approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JackTan25 JackTan25 marked this pull request as draft August 3, 2023 11:14
@sundy-li sundy-li mentioned this pull request Aug 4, 2023
Merged
@sundy-li
Copy link
Member

sundy-li commented Aug 4, 2023 •
edited
Loading

the branch name is ambiguous, continue in #12355

@sundy-li sundy-li closed this Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@sundy-li sundy-li sundy-li approved these changes

@xudong963 xudong963 Awaiting requested review from xudong963

Assignees
No one assigned
Labels
ci-cloud Build docker image for cloud test pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JackTan25 @sundy-li @Xuanwo @xudong963