-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(geo): add geometry data type #14470
Conversation
Each type of Geometry has a different definition, and there seems to be a difference in the type definitions used. In addition, postgis, for example, also has a good guide to the use and definition of each type declaration: geom geometry(multilinestring, 3857) Hope these will be helpful to the improvement of this PR. And if there's anything I can do to help, let me know. |
Geometry have many types. Each type has own memory layout which is described in geoarrow spec . I think we will import geoarrow-r craft and define GeometryType as below:
|
Hi @cdmikechen @kkk25641463 , thanks for your interest in this feature. We will follow the snowflake approach to deal with GEO types. Support geoparquet not planed. cc @cdmikechen Support sub-types for geo type is not our approach now, since databend is a snowflake alternative we will follow it's way, related PR is closed. cc @kkk25641463 BTW: I'll plan to use geozero to read/store |
09a9450
to
4558ebf
Compare
Add a new version and a corresponding test: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 50 files at r2, 5 of 26 files at r3.
Reviewable status: 10 of 61 files reviewed, 13 unresolved discussions (waiting on @ariesdevil, @b41sh, @kkk25641463, and @sundy-li)
031b107
to
09df85f
Compare
@ariesdevil |
@cdmikechen |
Here are snowflake documents: If we want to return a geometry point, should we use |
Yep, I'll fix it in next PR, thanks figure it out。 |
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Initial support geometry type. We use
EWKB
for serialize geo data and useEWKT
for display geo data.part of #14543
Tests
Type of change
This change is