Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(meta): remove tenant for table info #14647

Merged
merged 4 commits into from
Feb 8, 2024

Conversation

zhang2014
Copy link
Member

@zhang2014 zhang2014 commented Feb 8, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

chore(meta): remove tenant for table info

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Feb 8, 2024
@zhang2014 zhang2014 requested a review from BohuTANG February 8, 2024 11:29
@zhang2014 zhang2014 marked this pull request as draft February 8, 2024 11:40
@zhang2014 zhang2014 changed the title chore(executor): remove catalog ident name for profile chore(meta): remove tenant for table info Feb 8, 2024
@zhang2014 zhang2014 requested a review from drmingdrmer February 8, 2024 11:55
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice shot

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @BohuTANG)

@zhang2014 zhang2014 marked this pull request as ready for review February 8, 2024 12:40
@zhang2014 zhang2014 enabled auto-merge February 8, 2024 12:52
@zhang2014 zhang2014 added this pull request to the merge queue Feb 8, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Feb 8, 2024
@BohuTANG BohuTANG merged commit ec91213 into databendlabs:main Feb 8, 2024
73 of 74 checks passed
SkyFan2002 added a commit to SkyFan2002/databend that referenced this pull request Feb 23, 2024
BohuTANG pushed a commit that referenced this pull request Feb 26, 2024
* init

* state machine

* init txn catalog

* replace default catalog

* fix is_ddl

* revert

* modify catalog interface

* make lint

* fix ut

* fix state

* fix mysql check

* refactor

* get table meta from local buffer

* commit

* fix todo

* fix todo

* rr stream

* make lint

* fix header

* fix mysql

* rename function

* fix todo

* fix error code

* fix mysql error capture

* remove debug info

* adjust syntax

* try fix stream

* fix

* make lint

* make lint

* fix refresh table

* respect pr #14647

* support dedup label

* fix merge

* refactor txn buffer

* add sql logic tests (provided by @SkyFan2002)

* fix: mv sqlogic test txn_stream into ee directory

* get_table_copied_file_info from txn buffer

* tweak file structure

* delay purge files

* clear table cache in ddl

* use parking_lot::Mutex

---------

Co-authored-by: dantengsky <dantengsky@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants