Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): link with mold in build-tool #4681

Merged
merged 3 commits into from
Apr 3, 2022
Merged

Conversation

everpcpc
Copy link
Member

@everpcpc everpcpc commented Apr 2, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

link with mold for debug linux gnu

with mold

on x86_64-unknown-linux-gnu

 Finished dev [unoptimized + debuginfo] target(s) in 3m 26s

String dump of section '.comment':
  [     0]  GCC: (Debian 10.2.1-6) 10.2.1 20210110
  [    27]  mold 1.1.1 (c1af9c97e763a1d521889191a83b27bd6c43b351; compatible with GNU ld)
  [    75]  clang version 13.0.0

on aarch64-unknown-linux-gnu

Finished dev [unoptimized + debuginfo] target(s) in 3m 38s

String dump of section '.comment':
  [     0]  GCC: (Debian 10.2.1-6) 10.2.1 20210110
  [    27]  mold 1.1.1 (c1af9c97e763a1d521889191a83b27bd6c43b351; compatible with GNU ld)
  [    75]  GCC: (crosstool-NG ) 5.2.0

without mold

on x86_64-unknown-linux-gnu

Finished dev [unoptimized + debuginfo] target(s) in 5m 53s

String dump of section '.comment':
  [     0]  GCC: (Debian 10.2.1-6) 10.2.1 20210110
  [    27]  clang version 13.0.0

on aarch64-unknown-linux-gnu

Finished dev [unoptimized + debuginfo] target(s) in 5m 11s

String dump of section '.comment':
  [     0]  GCC: (Debian 10.2.1-6) 10.2.1 20210110
  [    27]  GCC: (crosstool-NG ) 5.2.0

Changelog

  • Build/Testing/CI

Related Issues

Fixes #4180

Test Plan

Unit Tests

Stateless Tests

@vercel
Copy link

vercel bot commented Apr 2, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/5jYqqu4fkmqLZ1Dv2EpSL4wbQ7un
✅ Preview: https://databend-git-fork-everpcpc-ci-mold-databend.vercel.app

@mergify
Copy link
Contributor

mergify bot commented Apr 2, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@everpcpc everpcpc changed the title chore: try link with mold chore(ci): link with mold in build-tool Apr 3, 2022
@everpcpc everpcpc marked this pull request as ready for review April 3, 2022 06:51
@everpcpc everpcpc requested a review from BohuTANG as a code owner April 3, 2022 06:51
@everpcpc everpcpc requested review from Xuanwo and PsiACE April 3, 2022 06:52
@Xuanwo
Copy link
Member

Xuanwo commented Apr 3, 2022

@ClSlaid used to work on the same issue #4196, invited for a review, and thanks for his hard work!

@mergify mergify bot merged commit e3dc7dc into databendlabs:main Apr 3, 2022
@everpcpc everpcpc deleted the ci-mold branch April 3, 2022 08:41
@ClSlaid
Copy link
Contributor

ClSlaid commented Apr 3, 2022

The PR seems to work by replacing the GNU Gold with mold. It's good but, will it also replace the builder for aarch64-linux-unknown-gnu? @Xuanwo

@everpcpc
Copy link
Member Author

everpcpc commented Apr 3, 2022

The PR seems to work by replacing the GNU Gold with mold. It's good but, will it also replace the builder for aarch64-linux-unknown-gnu? @Xuanwo

Yes, it will replace ld under x86_64 and aarch64.
They both working with the mold binary release:

mold: supported targets: elf32-i386 elf64-x86-64 elf64-littleaarch64
mold: supported emulations: elf_i386 elf_x86_64 aarch64linux aarch64elf

Copy link
Contributor

@ClSlaid ClSlaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nice and clear, looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-build this PR changes build/testing/ci steps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][CI] replace CI's linker with mold
5 participants