Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes(limit): fixes limit and offset with one block #4907

Merged
merged 6 commits into from
Apr 18, 2022

Conversation

zhang2014
Copy link
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

fixes(limit): fixes limit and offset with one block

Changelog

  • Bug Fix

Related Issues

Fixes #4807

@vercel
Copy link

vercel bot commented Apr 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Apr 18, 2022 at 5:43AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Apr 18, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Apr 18, 2022
@BohuTANG
Copy link
Member

Two test need handle:

   /workspace/tests/suites/0_stateless/01_system/01_0004_system_engines.sql
    /workspace/tests/suites/0_stateless/03_dml/03_0019_select_empty.sql

@BohuTANG
Copy link
Member

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Apr 18, 2022

update

✅ Branch has been successfully updated

@BohuTANG
Copy link
Member

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Apr 18, 2022

update

✅ Branch has been successfully updated

@BohuTANG BohuTANG merged commit 3fc77dd into databendlabs:main Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: If use SELECT LIMIT query a table that the data is not batch insert the result of query will not stable
4 participants