Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(functions): use drop guard to ensure the states dropped #5097

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

sundy-li
Copy link
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

  1. Remove SingleKeyAggregator to SingleStateAggregator, this avoids confusion.
  2. Use drop guard to ensure the states dropped even if panic happens.

Changelog

  • Bug Fix
  • Improvement

Related Issues

Fixes #issue

@vercel
Copy link

vercel bot commented Apr 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Apr 29, 2022 at 0:30AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Apr 29, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added pr-bugfix this PR patches a bug in codebase pr-improvement labels Apr 29, 2022
@BohuTANG BohuTANG merged commit 0bc7167 into databendlabs:main Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants