-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix(pipeline): Fix state machine of hash join #5242
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
LGTM. |
It's just somewhat glue code. I'm going to do some decouple work on the concepts |
@@ -65,4 +65,6 @@ drop table t; | |||
drop table t1; | |||
drop table t2; | |||
|
|||
select count(*) from numbers(1000) as t inner join numbers(1000) as t1 on t.number = t1.number; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why this is not working:
mysql> select * from numbers(1000) as t inner join numbers(1000) as t1 on t.number = t1.number;
ERROR 1105 (HY000): Code: 1002, displayText = Duplicate alias name :number (while in processor thread 0).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this is OK:
mysql> select t.number from numbers(1000) as t inner join numbers(1000) as t1 on t.number = t1.number;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's the same problem described in #5236
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Fix the bug that hash join probe transform won't emit
Finished
event.Changelog
Related Issues
Close #5234