Skip to content

Commit

Permalink
Add filer.Filer to read notebooks from WSFS without omitting their …
Browse files Browse the repository at this point in the history
…extension (#1457)

## Changes
This PR adds a filer that'll allow us to read notebooks from the WSFS
using their full paths (with the extension included). The filer relies
on the existing workspace filer (and consequently the workspace
import/export/list APIs).

Using this filer along with a virtual filesystem layer
(https://github.com/databricks/cli/pull/1452/files) will allow us to use
our custom implementation (which preserves the notebook extensions)
rather than the default mount available via DBR when the CLI is run from
DBR.

## Tests
Integration tests.

---------

Co-authored-by: Pieter Noordhuis <pieter.noordhuis@databricks.com>
  • Loading branch information
shreyas-goenka and pietern authored May 30, 2024
1 parent 424499e commit ec33a7c
Show file tree
Hide file tree
Showing 3 changed files with 702 additions and 0 deletions.
Loading

0 comments on commit ec33a7c

Please sign in to comment.