Move bundle schema update to an internal module #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-goenka
changed the title
pietern
reviewed
Nov 27, 2023
| @@ -36,30 +51,45 @@ | |||
| } | |||
| } | |||
| }, | |||
| "targets": { | |||
| "environments": { | |||
There was a problem hiding this comment.
What happened here? It looks like the environments block got reinstated with empty docs.
There was a problem hiding this comment.
This is expected. enviroments was renamed to -> targets here manually https://github.com/databricks/cli/pull/670/files#diff-2b39aa846db6105db22d39143a8474f599cd77a4085521636c97f0949a82f73a
Generating the docs manually from the bundle Go struct also generated docs for for enviroments. However this does not make a difference for the final generated enviroments schema.
There was a problem hiding this comment.
Please mask it out. I'd rather have a squiggly line on environments than valid autocompletion.
There was a problem hiding this comment.
Done. I have marked enviroments as "deprecated". From this point onwards it will not generated as part of the bundle schema.
pietern
reviewed
Dec 6, 2023
pietern
approved these changes
Dec 6, 2023
andrewnester
added a commit
that referenced
this pull request
Dec 6, 2023
CLI: * Add documentation for positional args in commands generated from the Databricks OpenAPI specification ([#1033](#1033)). * Ask for host when .databrickscfg doesn't exist ([#1041](#1041)). * Add list of supported values for flags that represent an enum field ([#1036](#1036)). Bundles: * Fix panic when bundle auth resolution fails ([#1002](#1002)). * Add versioning for bundle templates ([#972](#972)). * Add support for conditional prompting in bundle init ([#971](#971)). * Pass parameters to task when run with `--python-params` and `python_wheel_wrapper` is true ([#1037](#1037)). * Change default_python template to auto-update version on each wheel build ([#1034](#1034)). Internal: * Rewrite the friendly log handler ([#1038](#1038)). * Move bundle schema update to an internal module ([#1012](#1012)). Dependency updates: * Bump github.com/databricks/databricks-sdk-go from 0.26.0 to 0.26.1 ([#1040](#1040)).
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 6, 2023
CLI: * Add documentation for positional args in commands generated from the Databricks OpenAPI specification ([#1033](#1033)). * Ask for host when .databrickscfg doesn't exist ([#1041](#1041)). * Add list of supported values for flags that represent an enum field ([#1036](#1036)). Bundles: * Fix panic when bundle auth resolution fails ([#1002](#1002)). * Add versioning for bundle templates ([#972](#972)). * Add support for conditional prompting in bundle init ([#971](#971)). * Pass parameters to task when run with `--python-params` and `python_wheel_wrapper` is true ([#1037](#1037)). * Change default_python template to auto-update version on each wheel build ([#1034](#1034)). Internal: * Rewrite the friendly log handler ([#1038](#1038)). * Move bundle schema update to an internal module ([#1012](#1012)). Dependency updates: * Bump github.com/databricks/databricks-sdk-go from 0.26.0 to 0.26.1 ([#1040](#1040)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR:
bundle schemacommand. These flags were meant for internal processes and at no point were meant for customer use.bundle_descriptions.jsonbundle: "deprecated". Theenvironmentsfield is tagged as deprecated in this PR and consequently will no longer be a part of the bundle schema.Tests
Tested by regenerating the CLI against its current OpenAPI spec (as defined in
__openapi_sha). Thebundle_descriptions.jsonin this PR was generated from the code generator.Manually checked that the autocompletion / descriptions from the new bundle schema are correct.