Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an experimental default-sql template #1051
Add an experimental default-sql template #1051
Changes from 10 commits
c71aa4a
7abb3ad
2ce4ce3
9899d16
19e25f5
bd1b78d
7828c35
4b7c4a0
78d22eb
a9bdc64
ab43e1e
c207991
6124fbe
74df04e
ace64dd
a502bb1
3aa501e
cc2f66d
93d7052
9d6fb8c
2becf55
18860ca
a74a19d
e5fab2d
d46d247
97ef8fc
12b77ab
22176b2
d471666
bf70431
dcc3cb2
bdbd7f7
1c8f9ff
8572b3d
64851e7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
notebooks and SQL files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just talk about SQL files here. If we wanted to support notebooks then we should be adding a
requirements.txt
to configure the python env.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added SQL files. And notebooks are actually very useful for SQL at this point. They can be used with warehouses too (though probably not in the IDE, yet?)
Re. requirements.txt: is that used for notebooks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notebooks in the IDE currently use
spark.sql
so it's technically not the same. I could imagine adding a SQL mode to the notebooks just like in the webapp but that's currently not scoped.Notebooks can be used without virtual envs but that would clutter the global Python module space. If we recommend notebooks then using virtual envs and having a requirements.txt would be best practice.