Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test existing behavior when loading non-string spark conf values #1071

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

pietern
Copy link
Contributor

@pietern pietern commented Dec 18, 2023

Changes

This test is expected to fail when we enable the custom YAML loader.

This test is expected to fail when we enable the custom YAML loader.
@pietern pietern enabled auto-merge December 18, 2023 10:49
@pietern pietern requested a review from andrewnester December 18, 2023 10:50
@andrewnester
Copy link
Contributor

Just to double check, this config fails on databricks bundle validate right now, correct?

@pietern
Copy link
Contributor Author

pietern commented Dec 18, 2023

@andrewnester It does not -- it silently ignores chunks of the configuration.

@pietern pietern added this pull request to the merge queue Dec 18, 2023
@andrewnester
Copy link
Contributor

Ah right, it fails later at deploy stage, thanks

Merged via the queue into main with commit cee70a5 Dec 18, 2023
4 checks passed
@pietern pietern deleted the test-broken-spark-conf-behavior branch December 18, 2023 11:26
shreyas-goenka added a commit that referenced this pull request Dec 20, 2023
CLI:
 * Upgrade Go SDK to 0.27.0 ([#1064](#1064)).
 * Skip profile resolution if `DATABRICKS_AUTH_TYPE` is set ([#1068](#1068)).
 * Test existing behavior when loading non-string spark conf values ([#1071](#1071)).
 * Do not allow input prompts in Git Bash terminal ([#1069](#1069)).
 * Added output template for list-secrets command ([#1074](#1074)).
 * Set metadata fields required to enable break-glass UI for jobs ([#880](#880)).
 * Revert using IsPromptSupported from promptOrAssignDefaultValues ([#1077](#1077)).
 * Do not prompt for template values in Git Bash ([#1082](#1082)).

Bundles:
 * **FILL THIS IN MANUALLY BY MOVING RELEVANT ITEMS FROM ABOVE LIST**

Internal:
 * **FILL THIS IN MANUALLY BY MOVING RELEVANT ITEMS FROM ABOVE LIST**

API Changes:
 * Changed `databricks connections update` command with new required argument order.
 * Changed `databricks serving-endpoints update-config` command with new required argument order.
 * Added `databricks serving-endpoints put` command.
 * Removed `databricks account network-policy` command group.

OpenAPI commit 63caa3cb0c05045e81d3dcf2451fa990d8670f36 (2023-12-12)
Dependency updates:
 * Bump github.com/google/uuid from 1.4.0 to 1.5.0 ([#1073](#1073)).
 * Bump golang.org/x/crypto from 0.16.0 to 0.17.0 ([#1076](#1076)).
@shreyas-goenka shreyas-goenka mentioned this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants