Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error when bundle root is not writable #1093

Merged
merged 3 commits into from
Dec 28, 2023
Merged

Improve error when bundle root is not writable #1093

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d51177
Improve error when bundle root is not writable
lennartkats-db Dec 27, 2023
d5b997e
Add comment
lennartkats-db Dec 27, 2023
90202cd
Rename variable
lennartkats-db Dec 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions bundle/deploy/lock/acquire.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,11 @@ package lock

import (
"context"
"errors"
"fmt"

"github.com/databricks/cli/bundle"
"github.com/databricks/cli/libs/filer"
"github.com/databricks/cli/libs/locker"
"github.com/databricks/cli/libs/log"
)
Expand Down Expand Up @@ -47,6 +50,13 @@ func (m *acquire) Apply(ctx context.Context, b *bundle.Bundle) error {
err = b.Locker.Lock(ctx, force)
if err != nil {
log.Errorf(ctx, "Failed to acquire deployment lock: %v", err)

existError := filer.NoSuchDirectoryError{}
lennartkats-db marked this conversation as resolved.
Show resolved Hide resolved
if errors.As(err, &existError) {
// If we get a "doesn't exist" error from the API this indicates
// we either don't have permissions or the path is invalid.
return fmt.Errorf("cannot write to deployment root (this can indicate a previous deploy was done with a different identity): %s", b.Config.Workspace.RootPath)
}
return err
}

Expand Down