Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.217.0 #1337

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Release v0.217.0 #1337

merged 2 commits into from
Apr 3, 2024

Conversation

andrewnester
Copy link
Contributor

@andrewnester andrewnester commented Apr 3, 2024

Breaking Change:

  • Add allow list for resources when bundle run_as is set (#1233).
  • Make bundle validation print text output by default (#1335).

CLI:

  • Added auth describe command (#1244).
  • Fixed message for successful auth describe run (#1336).

Bundles:

  • Use UserName field to identify if service principal is used (#1310).
  • Allow unknown properties in the config file for template initialization (#1315).
  • Remove support for DATABRICKS_BUNDLE_INCLUDES (#1317).
  • Make bundle.deployment optional in the bundle schema (#1321).
  • Fix the generated DABs JSON schema (#1322).
  • Make bundle loaders return diagnostics (#1319).
  • Add bundle debug terraform command (#1294).
  • Allow specifying CLI version constraints required to run the bundle (#1320).

Internal:

  • Retain location information of variable reference (#1333).
  • Define dyn.Mapping to represent maps (#1301).
  • Return diag.Diagnostics from mutators (#1305).
  • Fix flaky test in libs/process (#1314).
  • Move path field to bundle type (#1316).
  • Load bundle configuration from mutator (#1318).
  • Return diagnostics from config.Load (#1324).
  • Return warning for nil primitive types during normalization (#1329).
  • Include dyn.Path in normalization warnings and errors (#1332).
  • Make normalization return warnings instead of errors (#1334).
    API Changes:
  • Added databricks lakeview migrate command.
  • Added databricks lakeview unpublish command.
  • Changed databricks ip-access-lists get command . New request type is .

OpenAPI commit e316cc3d78d087522a74650e26586088da9ac8cb (2024-04-03)
Dependency updates:

  • Bump github.com/databricks/databricks-sdk-go from 0.36.0 to 0.37.0 (#1326).

CLI:
 * Added `auth describe` command ([#1244](#1244)).
 * Fixed message for successful auth describe run ([#1336](#1336)).

Bundles:
 * Make bundle validation print text output by default ([#1335](#1335)).
 * Use UserName field to identify if service principal is used ([#1310](#1310)).
 * Allow unknown properties in the config file for template initialization ([#1315](#1315)).
 * Remove support for DATABRICKS_BUNDLE_INCLUDES ([#1317](#1317)).
 * Make `bundle.deployment` optional in the bundle schema ([#1321](#1321)).
 * Add allow list for resources when bundle `run_as` is set ([#1233](#1233)).
 * Fix the generated DABs JSON schema ([#1322](#1322)).
 * Make bundle loaders return diagnostics ([#1319](#1319)).
 * Add `bundle debug terraform` command ([#1294](#1294)).
 * Allow specifying CLI version constraints required to run the bundle ([#1320](#1320)).

Internal:
 * Retain location information of variable reference ([#1333](#1333)).
 * Define `dyn.Mapping` to represent maps ([#1301](#1301)).
 * Return `diag.Diagnostics` from mutators ([#1305](#1305)).
 * Fix flaky test in `libs/process` ([#1314](#1314)).
 * Move path field to bundle type ([#1316](#1316)).
 * Load bundle configuration from mutator ([#1318](#1318)).
 * Return diagnostics from `config.Load` ([#1324](#1324)).
 * Return warning for nil primitive types during normalization ([#1329](#1329)).
 * Include `dyn.Path` in normalization warnings and errors ([#1332](#1332)).
 * Make normalization return warnings instead of errors ([#1334](#1334)).

API Changes:
 * Added `databricks lakeview migrate` command.
 * Added `databricks lakeview unpublish` command.
 * Changed `databricks ip-access-lists get` command . New request type is .

OpenAPI commit e316cc3d78d087522a74650e26586088da9ac8cb (2024-04-03)
Dependency updates:
 * Bump github.com/databricks/databricks-sdk-go from 0.36.0 to 0.37.0 ([#1326](#1326)).
CHANGELOG.md Outdated
* Allow unknown properties in the config file for template initialization ([#1315](https://github.com/databricks/cli/pull/1315)).
* Remove support for DATABRICKS_BUNDLE_INCLUDES ([#1317](https://github.com/databricks/cli/pull/1317)).
* Make `bundle.deployment` optional in the bundle schema ([#1321](https://github.com/databricks/cli/pull/1321)).
* Add allow list for resources when bundle `run_as` is set ([#1233](https://github.com/databricks/cli/pull/1233)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change breaks workflows for admins who used run_as on their DLT pipelines. Their DABs will now start to fail deployments. Can we highlight that this change is breaking?

As a side note, we don't have an easy migration path for customers here because the underlying tables also use the "owner" of the DLT pipeline as the identity. Lets wait and see if this impacts more than a few customers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shreyas-goenka updated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also include the context in which it is breaking? That is bundle deploy will now start failing if the DAB was deployed by a workspace admin and uses bundle.run_as to set the owner of a DLT pipeline.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shreyas-goenka I'd keep Changelog format consistent and don't deviate from ot and rather add the context of the breaking change in the PR description itself
#1233
Could you please describe breaking changes in you PR description?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, edited the PR description to include the conditions where deployment would break.

@andrewnester andrewnester added this pull request to the merge queue Apr 3, 2024
Merged via the queue into main with commit 6ac45e8 Apr 3, 2024
5 checks passed
@andrewnester andrewnester deleted the prepare/0.217.0 branch April 3, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants