Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/databricks/databricks-sdk-go from 0.37.0 to 0.38.0 #1361

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Bump github.com/databricks/databricks-sdk-go from 0.37.0 to 0.38.0 #1361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d28b18
Bump github.com/databricks/databricks-sdk-go from 0.37.0 to 0.38.0
dependabot[bot] Apr 15, 2024
0dd577d
fixes
andrewnester Apr 15, 2024
8254e56
fix test
andrewnester Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .codegen/_openapi_sha
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
e316cc3d78d087522a74650e26586088da9ac8cb
94684175b8bd65f8701f89729351f8069e8309c9
8 changes: 7 additions & 1 deletion .codegen/service.go.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,13 @@ func new{{.PascalName}}() *cobra.Command {
{{- end}}
{{end}}

{{- $excludeFromPrompts := list "workspace get-status" -}}
{{- $excludeFromPrompts := list
"workspace get-status"
"provider-exchanges get"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

temporarily disabled until resolved on SDK side (need to store Request reference in NamedIdMap so the correct request type is used in request later)

"provider-exchanges delete"
"provider-exchanges delete-listing-from-exchange"
"provider-exchanges list-exchanges-for-listing"
-}}
{{- $fullCommandName := (print $serviceName " " .KebabName) -}}
{{- $noPrompt := or .IsCrudCreate (in $excludeFromPrompts $fullCommandName) }}

Expand Down
12 changes: 12 additions & 0 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,11 @@ cmd/workspace/cluster-policies/cluster-policies.go linguist-generated=true
cmd/workspace/clusters/clusters.go linguist-generated=true
cmd/workspace/cmd.go linguist-generated=true
cmd/workspace/connections/connections.go linguist-generated=true
cmd/workspace/consumer-fulfillments/consumer-fulfillments.go linguist-generated=true
cmd/workspace/consumer-installations/consumer-installations.go linguist-generated=true
cmd/workspace/consumer-listings/consumer-listings.go linguist-generated=true
cmd/workspace/consumer-personalization-requests/consumer-personalization-requests.go linguist-generated=true
cmd/workspace/consumer-providers/consumer-providers.go linguist-generated=true
cmd/workspace/credentials-manager/credentials-manager.go linguist-generated=true
cmd/workspace/csp-enablement/csp-enablement.go linguist-generated=true
cmd/workspace/current-user/current-user.go linguist-generated=true
Expand Down Expand Up @@ -68,6 +73,13 @@ cmd/workspace/permission-migration/permission-migration.go linguist-generated=tr
cmd/workspace/permissions/permissions.go linguist-generated=true
cmd/workspace/pipelines/pipelines.go linguist-generated=true
cmd/workspace/policy-families/policy-families.go linguist-generated=true
cmd/workspace/provider-exchange-filters/provider-exchange-filters.go linguist-generated=true
cmd/workspace/provider-exchanges/provider-exchanges.go linguist-generated=true
cmd/workspace/provider-files/provider-files.go linguist-generated=true
cmd/workspace/provider-listings/provider-listings.go linguist-generated=true
cmd/workspace/provider-personalization-requests/provider-personalization-requests.go linguist-generated=true
cmd/workspace/provider-provider-analytics-dashboards/provider-provider-analytics-dashboards.go linguist-generated=true
cmd/workspace/provider-providers/provider-providers.go linguist-generated=true
cmd/workspace/providers/providers.go linguist-generated=true
cmd/workspace/queries/queries.go linguist-generated=true
cmd/workspace/query-history/query-history.go linguist-generated=true
Expand Down
4 changes: 2 additions & 2 deletions bundle/config/mutator/override_compute.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@ func overrideJobCompute(j *resources.Job, compute string) {
task = &task.ForEachTask.Task
}

if task.NewCluster != nil || task.ExistingClusterId != "" || task.ComputeKey != "" || task.JobClusterKey != "" {
if task.NewCluster != nil || task.ExistingClusterId != "" || task.EnvironmentKey != "" || task.JobClusterKey != "" {
task.NewCluster = nil
task.JobClusterKey = ""
task.ComputeKey = ""
task.EnvironmentKey = ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rename / deprecation happened on SDK side which is potentially a breaking change on CLI / DABs side as well

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ComputeKey was in private preview and deprecated in favour of EnvironmentKey so safe to make the change

task.ExistingClusterId = compute
}
}
Expand Down
4 changes: 2 additions & 2 deletions bundle/config/mutator/override_compute_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ func TestOverrideDevelopment(t *testing.T) {
ExistingClusterId: "cluster2",
},
{
ComputeKey: "compute_key",
EnvironmentKey: "environment_key",
},
{
JobClusterKey: "cluster_key",
Expand All @@ -58,7 +58,7 @@ func TestOverrideDevelopment(t *testing.T) {
assert.Equal(t, "newClusterID", b.Config.Resources.Jobs["job1"].Tasks[3].ExistingClusterId)

assert.Nil(t, b.Config.Resources.Jobs["job1"].Tasks[0].NewCluster)
assert.Empty(t, b.Config.Resources.Jobs["job1"].Tasks[2].ComputeKey)
assert.Empty(t, b.Config.Resources.Jobs["job1"].Tasks[2].EnvironmentKey)
assert.Empty(t, b.Config.Resources.Jobs["job1"].Tasks[3].JobClusterKey)
}

Expand Down
174 changes: 112 additions & 62 deletions bundle/schema/docs/bundle_descriptions.json
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions cmd/account/workspace-assignment/workspace-assignment.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions cmd/workspace/clusters/clusters.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 24 additions & 0 deletions cmd/workspace/cmd.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

162 changes: 162 additions & 0 deletions cmd/workspace/consumer-fulfillments/consumer-fulfillments.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading