Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filer.Filer to read notebooks from WSFS without omitting their extension #1457

Merged
merged 30 commits into from
May 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
0229dd3
wip
shreyas-goenka May 27, 2024
add2dd1
do not rely on fuse mount
shreyas-goenka May 27, 2024
fdacdcc
cleanup some todos and add test for dup name error
shreyas-goenka May 28, 2024
6ab53d5
more modular extension business
shreyas-goenka May 28, 2024
49a0b49
rename file
shreyas-goenka May 28, 2024
42e1bb5
add test for language check
shreyas-goenka May 28, 2024
b55c00e
better main documentation
shreyas-goenka May 28, 2024
f80d338
test for directories + notebook clash
shreyas-goenka May 28, 2024
c75b5e2
clear todos
shreyas-goenka May 28, 2024
a38295c
-
shreyas-goenka May 28, 2024
b514498
better error messagE
shreyas-goenka May 28, 2024
0fb56da
Merge remote-tracking branch 'origin' into wsfs-filer
shreyas-goenka May 28, 2024
deb2107
remove unnecessary sort
shreyas-goenka May 29, 2024
747ec5b
make multiline
shreyas-goenka May 29, 2024
c9a72c5
address more comments
shreyas-goenka May 29, 2024
8db2bd7
-
shreyas-goenka May 29, 2024
1324bba
address comments and fix the ipynb information loss:
shreyas-goenka May 29, 2024
4fec905
do not use error directive
shreyas-goenka May 29, 2024
4fe597f
final cleanup
shreyas-goenka May 29, 2024
628a592
Break out function for stat call
pietern May 30, 2024
8bd6449
Return error if we expect a notebook and it isn't; never return a nil…
pietern May 30, 2024
72538cf
Capitalize
pietern May 30, 2024
0b5d9f5
Move test assertions around; capitalize
pietern May 30, 2024
45786de
Download Jupyter notebook as IPYNB
pietern May 30, 2024
6ca5bce
Rename to be similar to workspace files client
pietern May 30, 2024
5af3855
Fix Jupyter contents check
pietern May 30, 2024
d219f13
Address comments
pietern May 30, 2024
dbeee88
Bubble up errors from stat calls
pietern May 30, 2024
55eaa2d
filer -> wsfs
pietern May 30, 2024
55662ce
Fix comment
pietern May 30, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading