Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the any type to be set to nil in convert.FromTyped #1518

Merged
merged 1 commit into from
Jun 21, 2024
+11 −0
Merged

Allow the any type to be set to nil in convert.FromTyped #1518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions libs/dyn/convert/from_typed.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ func fromTyped(src any, ref dyn.Value, options ...fromTypedOptions) (dyn.Value,
return fromTypedInt(srcv, ref, options...)
case reflect.Float32, reflect.Float64:
return fromTypedFloat(srcv, ref, options...)
case reflect.Invalid:
// If the value is untyped and not set (e.g. any type with nil value), we return nil.
return dyn.NilValue, nil
}

return dyn.InvalidValue, fmt.Errorf("unsupported type: %s", srcv.Kind())
Expand Down
8 changes: 8 additions & 0 deletions libs/dyn/convert/from_typed_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,3 +619,11 @@ func TestFromTypedFloatTypeError(t *testing.T) {
_, err := FromTyped(src, ref)
require.Error(t, err)
}

func TestFromTypedAnyNil(t *testing.T) {
var src any = nil
var ref = dyn.NilValue
nv, err := FromTyped(src, ref)
require.NoError(t, err)
assert.Equal(t, dyn.NilValue, nv)
}
Loading