Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor jobs path translation #1782

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Refactor jobs path translation #1782

merged 2 commits into from
Sep 24, 2024

Conversation

kanterov
Copy link
Contributor

@kanterov kanterov commented Sep 20, 2024 •
edited
Loading

Changes

Extract package for other modules to transform different kinds of paths in job resources.

Tests

Unit tests

@kanterov kanterov marked this pull request as draft September 20, 2024 14:42
@kanterov kanterov force-pushed the kanterov/refactor-jobs-paths branch 2 times, most recently from 7a24c99 to c983bb2 Compare September 20, 2024 15:24
@kanterov kanterov force-pushed the kanterov/refactor-jobs-paths branch from c983bb2 to 18bec2b Compare September 20, 2024 15:29
@kanterov kanterov marked this pull request as ready for review September 20, 2024 15:52
@kanterov kanterov requested a review from pietern September 20, 2024 15:52
@kanterov kanterov mentioned this pull request Sep 20, 2024
Open
@kanterov
Copy link
Contributor Author

Thanks @andrewnester, can you please add to the merge queue?

@andrewnester andrewnester added this pull request to the merge queue Sep 24, 2024
Merged via the queue into databricks:main with commit 490259a Sep 24, 2024
5 checks passed
pietern
pietern reviewed Sep 25, 2024
View reviewed changes
bundle/config/mutator/paths/job_paths_visitor.go
PathKindWithPrefix,
func(s string) bool {
return !libraries.IsLibraryLocal(s)
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this piece belongs in the original code. Then this routine (and package) is only concerned with visiting everything and what to do with these paths is something for the caller to decide. These entries can use a different Kind to differentiate what they contain.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rationale here is that if property specifies a PyPi library, it isn't really a path, so it doesn't need to be handled. I don't see a use-case when we want to visit PyPi libraries, but if we need that, it should be very fixable by adding a separate kind.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that makes sense. But then the code should be updated to no longer talk about rewriting but rather about just visiting or not visiting. It's the caller who decides what to do upon visiting.

andrewnester added a commit that referenced this pull request Oct 1, 2024
@andrewnester
[Release] Release v0.229.0
00a9724 
Bundles:
 * Added support for creating all-purpose clusters ([#1698](#1698)).
 * Reduce time until the prompt is shown for bundle run ([#1727](#1727)).
 * Use Unity Catalog for pipelines in the default-python template ([#1766](#1766)).
 * Add verbose flag to the "bundle deploy" command ([#1774](#1774)).
 * Fixed full variable override detection ([#1787](#1787)).
 * Add sub-extension to resource files in built-in templates ([#1777](#1777)).
 * Fix panic in `apply_presets.go` ([#1796](#1796)).

Internal:
 * Assert tokens are redacted in origin URL when username is not specified ([#1785](#1785)).
 * Refactor jobs path translation ([#1782](#1782)).
 * Add JobTaskClusterSpec validate mutator ([#1784](#1784)).
 * Pin Go toolchain to 1.22.7 ([#1790](#1790)).
 * Modify SetLocation test utility to take full locations as argument ([#1788](#1788)).
 * Simplified isFullVariableOverrideDef implementation ([#1791](#1791)).
 * Sort tasks by `task_key` before generating the Terraform configuration ([#1776](#1776)).
 * Trim trailing whitespace ([#1794](#1794)).
 * Move trampoline code into trampoline package ([#1793](#1793)).
 * Rename `RootPath` -> `BundleRootPath` ([#1792](#1792)).

API Changes:
 * Changed `databricks apps delete` command to return .
 * Changed `databricks apps deploy` command with new required argument order.
 * Changed `databricks apps start` command to return .
 * Changed `databricks apps stop` command to return .
 * Added `databricks temporary-table-credentials` command group.
 * Added `databricks serving-endpoints put-ai-gateway` command.
 * Added `databricks disable-legacy-access` command group.
 * Added `databricks account disable-legacy-features` command group.

OpenAPI commit 6f6b1371e640f2dfeba72d365ac566368656f6b6 (2024-09-19)
Dependency updates:
 * Upgrade to Go SDK 0.47.0 ([#1799](#1799)).
 * Upgrade to TF provider 1.52 ([#1781](#1781)).
 * Bump golang.org/x/mod from 0.20.0 to 0.21.0 ([#1758](#1758)).
 * Bump github.com/hashicorp/hc-install from 0.7.0 to 0.9.0 ([#1772](#1772)).
@andrewnester andrewnester mentioned this pull request Oct 1, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 1, 2024
@andrewnester
[Release] Release v0.229.0 (#1801)
c28d64f 
Bundles:
* Added support for creating all-purpose clusters
([#1698](#1698)).
* Reduce time until the prompt is shown for bundle run
([#1727](#1727)).
* Use Unity Catalog for pipelines in the default-python template
([#1766](#1766)).
* Add verbose flag to the "bundle deploy" command
([#1774](#1774)).
* Fixed full variable override detection
([#1787](#1787)).
* Add sub-extension to resource files in built-in templates
([#1777](#1777)).
* Fix panic in `apply_presets.go`
([#1796](#1796)).

Internal:
* Assert tokens are redacted in origin URL when username is not
specified ([#1785](#1785)).
* Refactor jobs path translation
([#1782](#1782)).
* Add JobTaskClusterSpec validate mutator
([#1784](#1784)).
* Pin Go toolchain to 1.22.7
([#1790](#1790)).
* Modify SetLocation test utility to take full locations as argument
([#1788](#1788)).
* Simplified isFullVariableOverrideDef implementation
([#1791](#1791)).
* Sort tasks by `task_key` before generating the Terraform configuration
([#1776](#1776)).
* Trim trailing whitespace
([#1794](#1794)).
* Move trampoline code into trampoline package
([#1793](#1793)).
* Rename `RootPath` -> `BundleRootPath`
([#1792](#1792)).

API Changes:
 * Changed `databricks apps delete` command to return .
* Changed `databricks apps deploy` command with new required argument
order.
 * Changed `databricks apps start` command to return .
 * Changed `databricks apps stop` command to return .
 * Added `databricks temporary-table-credentials` command group.
 * Added `databricks serving-endpoints put-ai-gateway` command.
 * Added `databricks disable-legacy-access` command group.
 * Added `databricks account disable-legacy-features` command group.

OpenAPI commit 6f6b1371e640f2dfeba72d365ac566368656f6b6 (2024-09-19)
Dependency updates:
* Upgrade to Go SDK 0.47.0
([#1799](#1799)).
* Upgrade to TF provider 1.52
([#1781](#1781)).
* Bump golang.org/x/mod from 0.20.0 to 0.21.0
([#1758](#1758)).
* Bump github.com/hashicorp/hc-install from 0.7.0 to 0.9.0
([#1772](#1772)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietern pietern pietern left review comments

@andrewnester andrewnester andrewnester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kanterov @pietern @andrewnester