Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Cluster permission to use ClusterId not JobId. #1818

Closed
wants to merge 2 commits into from
Closed

[Fix] Cluster permission to use ClusterId not JobId. #1818

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d5d89e
Cluster permission to use ClusterId not JobId.
mpreisser-poi Oct 9, 2024
db7eca2
Merge branch 'main' into cluster_permissions
mpreisser-poi Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundle/deploy/terraform/tfdyn/convert_cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ func (clusterConverter) Convert(ctx context.Context, key string, vin dyn.Value,

// Configure permissions for this resource.
if permissions := convertPermissionsResource(ctx, vin); permissions != nil {
permissions.JobId = fmt.Sprintf("${databricks_cluster.%s.id}", key)
permissions.ClusterId = fmt.Sprintf("${databricks_cluster.%s.id}", key)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! :) convert_clusters_test needs to be updated as well to assert for ClusterId and JobId as it does now

out.Permissions["cluster_"+key] = permissions
}

Expand Down
Loading