Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libs/dyn/jsonsaver #1862

Merged
merged 10 commits into from
Oct 29, 2024
Merged

Add libs/dyn/jsonsaver #1862

merged 10 commits into from
Oct 29, 2024

Conversation

pietern
Copy link
Contributor

@pietern pietern commented Oct 28, 2024

Changes

This package can be used to marshal a dyn.Value as JSON and retain the ordering of keys in a mapping. Unlike the default behavior of json.Marshal, the output does not encode HTML characters.

Otherwise, this is no different from using JSON.Marshal with v.AsAny().

Tests

Unit tests.

This package can be used to marshal a `dyn.Value` as JSON and retain the
ordering of keys in a mapping. The output does not encode HTML characters as
opposed to the default behavior of `json.Marshal`.

Otherwise this is no different from using `json.Marshal` with `v.AsAny()`.
@pietern pietern temporarily deployed to test-trigger-is October 28, 2024 15:21 — with GitHub Actions Inactive
@pietern pietern temporarily deployed to test-trigger-is October 28, 2024 15:26 — with GitHub Actions Inactive
Copy link
Contributor

@shreyas-goenka shreyas-goenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, most of the comments are minor except that we probably should have a few more tests.

libs/dyn/jsonsaver/encoder_test.go Outdated Show resolved Hide resolved
libs/dyn/jsonsaver/encoder_test.go Outdated Show resolved Hide resolved
libs/dyn/jsonsaver/encoder.go Show resolved Hide resolved
libs/dyn/jsonsaver/saver.go Outdated Show resolved Hide resolved
libs/dyn/jsonsaver/saver_test.go Outdated Show resolved Hide resolved
@pietern pietern temporarily deployed to test-trigger-is October 29, 2024 11:46 — with GitHub Actions Inactive
@pietern pietern temporarily deployed to test-trigger-is October 29, 2024 11:47 — with GitHub Actions Inactive
@pietern pietern temporarily deployed to test-trigger-is October 29, 2024 11:48 — with GitHub Actions Inactive
@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/11573218424

Copy link
Contributor

@shreyas-goenka shreyas-goenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@pietern pietern added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit fa25b92 Oct 29, 2024
8 checks passed
@pietern pietern deleted the jsonsaver branch October 29, 2024 15:40
andrewnester added a commit that referenced this pull request Oct 30, 2024
New features for Databricks Asset Bundles:
This release adds support for managing AI/BI dashboards as part of your bundle configuration. The `bundle generate` command is updated to support producing dashboard bundle configuration as well as dashboard payloads.
You can find an example configuration and walkthrough at https://github.com/databricks/bundle-examples/tree/main/knowledge_base/dashboard_nyc_taxi

Bundles:
 * Add support for AI/BI dashboards ([#1743](#1743)).
 * Added validator for folder permissions ([#1824](#1824)).
 * Add bundle generate variant for dashboards ([#1847](#1847)).
 * Use SetPermissions instead of UpdatePermissions when setting folder permissions based on top-level ones ([#1822](#1822)).

Internal:
 * Attempt to reduce test flakiness on Windows ([#1845](#1845)).
 * Reuse resource resolution code for the run command ([#1858](#1858)).
 * [Internal] Automatically trigger integration tests on PR ([#1857](#1857)).
 * Add privacy notice to README ([#1841](#1841)).
 * [Internal] Add test instructions for external contributors ([#1863](#1863)).
 * Add `libs/dyn/jsonsaver` ([#1862](#1862)).

Dependency updates:
 * Bump github.com/fatih/color from 1.17.0 to 1.18.0 ([#1861](#1861)).
github-merge-queue bot pushed a commit that referenced this pull request Oct 30, 2024
**New features for Databricks Asset Bundles:**

This release adds support for managing AI/BI dashboards as part of your
bundle configuration. The `bundle generate` command is updated to
support producing dashboard bundle configuration as well as a serialized
JSON representation of the dashboard.
You can find an example configuration and walkthrough at
https://github.com/databricks/bundle-examples/tree/main/knowledge_base/dashboard_nyc_taxi

CLI:
* Add privacy notice to README
([#1841](#1841)).

Bundles:
* Add support for AI/BI dashboards
([#1743](#1743)).
* Added validator for folder permissions
([#1824](#1824)).
* Add bundle generate variant for dashboards
([#1847](#1847)).
* Use SetPermissions instead of UpdatePermissions when setting folder
permissions based on top-level ones
([#1822](#1822)).

Internal:
* Attempt to reduce test flakiness on Windows
([#1845](#1845)).
* Reuse resource resolution code for the run command
([#1858](#1858)).
* [Internal] Automatically trigger integration tests on PR
([#1857](#1857)).
* [Internal] Add test instructions for external contributors
([#1863](#1863)).
* Add `libs/dyn/jsonsaver`
([#1862](#1862)).


Dependency updates:
* Bump github.com/fatih/color from 1.17.0 to 1.18.0
([#1861](#1861)).

---------

Co-authored-by: Pieter Noordhuis <pieter.noordhuis@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants