Added E2E test to run Python wheels on interactive cluster created in bundle #1864
+102
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
Test Details: go/deco-tests/11575017338 |
pietern
changed the title
pietern
approved these changes
Oct 31, 2024
| "type": "string", | ||
| "description": "Unique ID for job name" | ||
| }, | ||
| "instance_pool_id": { |
There was a problem hiding this comment.
This is not being used in the test, should we use it in the cluster specification to reduce the time this test takes to run?
There was a problem hiding this comment.
We create an interactive cluster as part of this test, so instance_pool_id needs to be removed
| func TestAccPythonWheelTaskDeployAndRunOnInteractiveCluster(t *testing.T) { | ||
| _, wt := acc.WorkspaceTest(t) | ||
|
|
||
| if testutil.IsAWSCloud(wt.T) { |
There was a problem hiding this comment.
You can create clusters on AWS right? Does the test runner not have enough permissions?
There was a problem hiding this comment.
it's a permission issue, yes
andrewnester
added a commit
that referenced
this pull request
Nov 6, 2024
CLI: * Clean host URL in the `auth login` command ([#1879](#1879)). Bundles: * Fix bundle run when run interactively ([#1880](#1880)). * Fix relative path resolution for dashboards on Windows ([#1881](#1881)). Internal: * Address goreleaser deprecation warning ([#1872](#1872)). * Update actions/github-script to v7 ([#1873](#1873)). * Use Go 1.23 ([#1871](#1871)). * [Internal] Always write message for manual integration test trigger ([#1874](#1874)). * Add `cmd-exec-id` to user agent ([#1808](#1808)). * Added E2E test to run Python wheels on interactive cluster created in bundle ([#1864](#1864)). Dependency updates: * Bump github.com/hashicorp/terraform-json from 0.22.1 to 0.23.0 ([#1877](#1877)).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 6, 2024
CLI: * Clean host URL in the `auth login` command ([#1879](#1879)). Bundles: * Fix bundle run when run interactively ([#1880](#1880)). * Fix relative path resolution for dashboards on Windows ([#1881](#1881)). Internal: * Address goreleaser deprecation warning ([#1872](#1872)). * Update actions/github-script to v7 ([#1873](#1873)). * Use Go 1.23 ([#1871](#1871)). * [Internal] Always write message for manual integration test trigger ([#1874](#1874)). * Add `cmd-exec-id` to user agent ([#1808](#1808)). * Added E2E test to run Python wheels on interactive cluster created in bundle ([#1864](#1864)). Dependency updates: * Bump github.com/hashicorp/terraform-json from 0.22.1 to 0.23.0 ([#1877](#1877)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added E2E test to run python wheels on interactive cluster created in bundle.
We had a gap in testing wheel on all purpose clusters, so this PR addresses the gap