Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/databricks/databricks-sdk-go from 0.49.0 to 0.51.0 #1878

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 4, 2024

Known issues:

  • (non-blocking with a command override) apps.Update requires 2 name params (one from path, one from request body)
  • (non-blocking) lakeview.Create does not require positional argument display_name anymore because it's not marked as required in request body

Bumps github.com/databricks/databricks-sdk-go from 0.49.0 to 0.51.0.

@dependabot dependabot bot added Dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Nov 4, 2024
@dependabot dependabot bot temporarily deployed to test-trigger-is November 4, 2024 11:44 Inactive
Bumps [github.com/databricks/databricks-sdk-go](https://github.com/databricks/databricks-sdk-go) from 0.49.0 to 0.50.0.
- [Release notes](https://github.com/databricks/databricks-sdk-go/releases)
- [Changelog](https://github.com/databricks/databricks-sdk-go/blob/main/CHANGELOG.md)
- [Commits](databricks/databricks-sdk-go@v0.49.0...v0.50.0)

---
updated-dependencies:
- dependency-name: github.com/databricks/databricks-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/databricks/databricks-sdk-go-0.50.0 branch from 57df4ac to 73f832b Compare November 4, 2024 14:46
@dependabot dependabot bot temporarily deployed to test-trigger-is November 4, 2024 14:46 Inactive
@andrewnester
Copy link
Contributor

@pietern there are some manual changes to dashboard code here, could you TAL?

Create a draft dashboard.

Arguments:
DISPLAY_NAME: The display name of the dashboard.`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewnester andrewnester self-requested a review November 8, 2024 13:15
cmd/workspace/apps/apps.go Outdated Show resolved Hide resolved
cmd/workspace/lakeview/lakeview.go Outdated Show resolved Hide resolved

cmd.Use = "update NAME"
cmd.Use = "update NAME NAME"
Copy link
Contributor

@andrewnester andrewnester Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now NAME param is in both request body and path with no good way for us to disambiguate this when generating. @pietern any ideas how do we address this for CLI? It might as well be necessary to fix it in OpenAPI

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewnester andrewnester changed the title Bump github.com/databricks/databricks-sdk-go from 0.49.0 to 0.50.0 Bump github.com/databricks/databricks-sdk-go from 0.49.0 to 0.51.0 Nov 11, 2024
@databricks databricks deleted a comment from dependabot bot Nov 11, 2024
cmd.Flags().StringVar(&createReq.WarehouseId, "warehouse-id", createReq.WarehouseId, `The warehouse ID used to run the dashboard.`)
cmd.Flags().StringVar(&createReq.Dashboard.DisplayName, "display-name", createReq.Dashboard.DisplayName, `The display name of the dashboard.`)
cmd.Flags().StringVar(&createReq.Dashboard.SerializedDashboard, "serialized-dashboard", createReq.Dashboard.SerializedDashboard, `The contents of the dashboard in serialized string form.`)
cmd.Flags().StringVar(&createReq.Dashboard.WarehouseId, "warehouse-id", createReq.Dashboard.WarehouseId, `The warehouse ID used to run the dashboard.`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why parent_path is gone?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's marked as computed field in proto and we do not list such fields as flags anymore

Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/cli

Inputs:

  • PR number: 1878
  • Commit SHA: d29f876bc822cbe77442c0078e6da96470eeb82b

Checks will be approved automatically on success.

@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/11816191009

@andrewnester andrewnester added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit 25838ee Nov 13, 2024
10 checks passed
@andrewnester andrewnester deleted the dependabot/go_modules/github.com/databricks/databricks-sdk-go-0.50.0 branch November 13, 2024 13:48
andrewnester added a commit that referenced this pull request Nov 14, 2024
Bundles:
 * Do not execute build on bundle destroy ([#1882](#1882)).
 * Add support for non-Python ipynb notebooks to DABs ([#1827](#1827)).

API Changes:
 * Added `databricks credentials` command group.
 * Changed `databricks genie execute-message-query` command to type `databricks genie execute-message-query` command.
 * Changed `databricks lakeview create` command with new required argument order.
 * Added `databricks aibi-dashboard-embedding-access-policy` command group.
 * Added `databricks aibi-dashboard-embedding-approved-domains` command group.
 * Removed `databricks clean-rooms` command group.

OpenAPI commit d25296d2f4aa7bd6195c816fdf82e0f960f775da (2024-11-07)
Dependency updates:
 * Upgrade TF provider to 1.58.0 ([#1900](#1900)).
 * Bump golang.org/x/sync from 0.8.0 to 0.9.0 ([#1892](#1892)).
 * Bump golang.org/x/text from 0.19.0 to 0.20.0 ([#1893](#1893)).
 * Bump golang.org/x/mod from 0.21.0 to 0.22.0 ([#1895](#1895)).
 * Bump golang.org/x/oauth2 from 0.23.0 to 0.24.0 ([#1894](#1894)).
 * Bump github.com/databricks/databricks-sdk-go from 0.49.0 to 0.51.0 ([#1878](#1878)).
github-merge-queue bot pushed a commit that referenced this pull request Nov 14, 2024
Bundles:
* Do not execute build on bundle destroy
([#1882](#1882)).
* Add support for non-Python ipynb notebooks to DABs
([#1827](#1827)).

API Changes:
 * Added `databricks credentials` command group.
* Changed `databricks lakeview create` command with new required
argument order.

OpenAPI commit d25296d2f4aa7bd6195c816fdf82e0f960f775da (2024-11-07)
Dependency updates:
* Upgrade TF provider to 1.58.0
([#1900](#1900)).
* Bump golang.org/x/sync from 0.8.0 to 0.9.0
([#1892](#1892)).
* Bump golang.org/x/text from 0.19.0 to 0.20.0
([#1893](#1893)).
* Bump golang.org/x/mod from 0.21.0 to 0.22.0
([#1895](#1895)).
* Bump golang.org/x/oauth2 from 0.23.0 to 0.24.0
([#1894](#1894)).
* Bump github.com/databricks/databricks-sdk-go from 0.49.0 to 0.51.0
([#1878](#1878)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants