-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump github.com/databricks/databricks-sdk-go from 0.49.0 to 0.51.0 #1878
Bump github.com/databricks/databricks-sdk-go from 0.49.0 to 0.51.0 #1878
Conversation
Bumps [github.com/databricks/databricks-sdk-go](https://github.com/databricks/databricks-sdk-go) from 0.49.0 to 0.50.0. - [Release notes](https://github.com/databricks/databricks-sdk-go/releases) - [Changelog](https://github.com/databricks/databricks-sdk-go/blob/main/CHANGELOG.md) - [Commits](databricks/databricks-sdk-go@v0.49.0...v0.50.0) --- updated-dependencies: - dependency-name: github.com/databricks/databricks-sdk-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
57df4ac
to
73f832b
Compare
@pietern there are some manual changes to dashboard code here, could you TAL? |
…databricks-sdk-go-0.50.0
Create a draft dashboard. | ||
|
||
Arguments: | ||
DISPLAY_NAME: The display name of the dashboard.` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be caused by display_name not marked as required in the OpenAPI https://github.com/databricks/databricks-sdk-go/blame/776b63cf7f8f155f7642b0320d2bea0ced011914/service/dashboards/model.go#L54
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
cmd.Use = "update NAME" | ||
cmd.Use = "update NAME NAME" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now NAME param is in both request body and path with no good way for us to disambiguate this when generating. @pietern any ideas how do we address this for CLI? It might as well be necessary to fix it in OpenAPI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmd.Flags().StringVar(&createReq.WarehouseId, "warehouse-id", createReq.WarehouseId, `The warehouse ID used to run the dashboard.`) | ||
cmd.Flags().StringVar(&createReq.Dashboard.DisplayName, "display-name", createReq.Dashboard.DisplayName, `The display name of the dashboard.`) | ||
cmd.Flags().StringVar(&createReq.Dashboard.SerializedDashboard, "serialized-dashboard", createReq.Dashboard.SerializedDashboard, `The contents of the dashboard in serialized string form.`) | ||
cmd.Flags().StringVar(&createReq.Dashboard.WarehouseId, "warehouse-id", createReq.Dashboard.WarehouseId, `The warehouse ID used to run the dashboard.`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know why parent_path
is gone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's marked as computed field in proto and we do not list such fields as flags anymore
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Test Details: go/deco-tests/11816191009 |
Bundles: * Do not execute build on bundle destroy ([#1882](#1882)). * Add support for non-Python ipynb notebooks to DABs ([#1827](#1827)). API Changes: * Added `databricks credentials` command group. * Changed `databricks genie execute-message-query` command to type `databricks genie execute-message-query` command. * Changed `databricks lakeview create` command with new required argument order. * Added `databricks aibi-dashboard-embedding-access-policy` command group. * Added `databricks aibi-dashboard-embedding-approved-domains` command group. * Removed `databricks clean-rooms` command group. OpenAPI commit d25296d2f4aa7bd6195c816fdf82e0f960f775da (2024-11-07) Dependency updates: * Upgrade TF provider to 1.58.0 ([#1900](#1900)). * Bump golang.org/x/sync from 0.8.0 to 0.9.0 ([#1892](#1892)). * Bump golang.org/x/text from 0.19.0 to 0.20.0 ([#1893](#1893)). * Bump golang.org/x/mod from 0.21.0 to 0.22.0 ([#1895](#1895)). * Bump golang.org/x/oauth2 from 0.23.0 to 0.24.0 ([#1894](#1894)). * Bump github.com/databricks/databricks-sdk-go from 0.49.0 to 0.51.0 ([#1878](#1878)).
Bundles: * Do not execute build on bundle destroy ([#1882](#1882)). * Add support for non-Python ipynb notebooks to DABs ([#1827](#1827)). API Changes: * Added `databricks credentials` command group. * Changed `databricks lakeview create` command with new required argument order. OpenAPI commit d25296d2f4aa7bd6195c816fdf82e0f960f775da (2024-11-07) Dependency updates: * Upgrade TF provider to 1.58.0 ([#1900](#1900)). * Bump golang.org/x/sync from 0.8.0 to 0.9.0 ([#1892](#1892)). * Bump golang.org/x/text from 0.19.0 to 0.20.0 ([#1893](#1893)). * Bump golang.org/x/mod from 0.21.0 to 0.22.0 ([#1895](#1895)). * Bump golang.org/x/oauth2 from 0.23.0 to 0.24.0 ([#1894](#1894)). * Bump github.com/databricks/databricks-sdk-go from 0.49.0 to 0.51.0 ([#1878](#1878)).
Known issues:
apps.Update
requires 2name
params (one from path, one from request body)lakeview.Create
does not require positional argumentdisplay_name
anymore because it's not marked as required in request bodyBumps github.com/databricks/databricks-sdk-go from 0.49.0 to 0.51.0.