Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add golangci-lint v1.62.2 #1953

Merged
merged 16 commits into from
Dec 4, 2024
Merged

Add golangci-lint v1.62.2 #1953

merged 16 commits into from
Dec 4, 2024

Conversation

denik
Copy link
Contributor

@denik denik commented Dec 3, 2024

No description provided.

@denik denik temporarily deployed to test-trigger-is December 3, 2024 13:37 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is December 3, 2024 13:38 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is December 3, 2024 13:50 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is December 3, 2024 13:50 — with GitHub Actions Inactive
@denik denik changed the title Add github action golanci v1.62.2 Add golangci v1.62.2 Dec 3, 2024
@denik denik temporarily deployed to test-trigger-is December 3, 2024 14:00 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is December 3, 2024 14:00 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is December 3, 2024 14:05 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is December 3, 2024 14:06 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is December 3, 2024 14:46 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is December 3, 2024 14:46 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is December 3, 2024 15:21 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is December 3, 2024 15:21 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is December 4, 2024 10:23 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is December 4, 2024 10:23 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is December 4, 2024 13:40 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is December 4, 2024 13:41 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is December 4, 2024 13:42 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is December 4, 2024 13:42 — with GitHub Actions Inactive
This more precise, only affects a given line and not all matching lines.
@denik denik temporarily deployed to test-trigger-is December 4, 2024 13:56 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is December 4, 2024 13:56 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is December 4, 2024 14:19 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is December 4, 2024 14:19 — with GitHub Actions Inactive
@denik denik requested review from andrewnester and pietern December 4, 2024 14:19
Copy link
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you combine the //nolint comments into the existing comment?

@denik denik temporarily deployed to test-trigger-is December 4, 2024 15:21 — with GitHub Actions Inactive
Copy link

github-actions bot commented Dec 4, 2024

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/cli

Inputs:

  • PR number: 1953
  • Commit SHA: 4639a73343851fc15fe442f280c73059d7673dd5

Checks will be approved automatically on success.

@denik denik temporarily deployed to test-trigger-is December 4, 2024 15:22 — with GitHub Actions Inactive
@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/12162833689

@denik denik changed the title Add golangci v1.62.2 Add golangci-lint v1.62.2 Dec 4, 2024
@denik denik added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit 0a36681 Dec 4, 2024
11 checks passed
@denik denik deleted the Add-golangci-lint branch December 4, 2024 17:49
pietern added a commit that referenced this pull request Dec 5, 2024
**New features for Databricks Asset Bundles:**

This release adds support for managing Unity Catalog volumes as part of your bundle configuration.

Bundles:
 * Add DABs support for Unity Catalog volumes ([#1762](#1762)).
 * Support lookup by name of notification destinations ([#1922](#1922)).
 * Extend "notebook not found" error to warn about missing extension ([#1920](#1920)).
 * Skip sync warning if no sync paths are defined ([#1926](#1926)).
 * Add validation for single node clusters ([#1909](#1909)).
 * Fix segfault in bundle summary command ([#1937](#1937)).
 * Add the `bundle_uuid` helper function for templates ([#1947](#1947)).
 * Add default value for `volume_type` for DABs ([#1952](#1952)).
 * Properly read Git metadata when running inside workspace ([#1945](#1945)).
 * Upgrade TF provider to 1.59.0 ([#1960](#1960)).

Internal:
 * Breakout variable lookup into separate files and tests ([#1921](#1921)).
 * Add golangci-lint v1.62.2 ([#1953](#1953)).

Dependency updates:
 * Bump golang.org/x/term from 0.25.0 to 0.26.0 ([#1907](#1907)).
 * Bump github.com/Masterminds/semver/v3 from 3.3.0 to 3.3.1 ([#1930](#1930)).
 * Bump github.com/stretchr/testify from 1.9.0 to 1.10.0 ([#1932](#1932)).
 * Bump github.com/databricks/databricks-sdk-go from 0.51.0 to 0.52.0 ([#1931](#1931)).
github-merge-queue bot pushed a commit that referenced this pull request Dec 5, 2024
**New features for Databricks Asset Bundles:**

This release adds support for managing Unity Catalog volumes as part of
your bundle configuration.

Bundles:
* Add DABs support for Unity Catalog volumes
([#1762](#1762)).
* Support lookup by name of notification destinations
([#1922](#1922)).
* Extend "notebook not found" error to warn about missing extension
([#1920](#1920)).
* Skip sync warning if no sync paths are defined
([#1926](#1926)).
* Add validation for single node clusters
([#1909](#1909)).
* Fix segfault in bundle summary command
([#1937](#1937)).
* Add the `bundle_uuid` helper function for templates
([#1947](#1947)).
* Add default value for `volume_type` for DABs
([#1952](#1952)).
* Properly read Git metadata when running inside workspace
([#1945](#1945)).
* Upgrade TF provider to 1.59.0
([#1960](#1960)).

Internal:
* Breakout variable lookup into separate files and tests
([#1921](#1921)).
* Add golangci-lint v1.62.2
([#1953](#1953)).

Dependency updates:
* Bump golang.org/x/term from 0.25.0 to 0.26.0
([#1907](#1907)).
* Bump github.com/Masterminds/semver/v3 from 3.3.0 to 3.3.1
([#1930](#1930)).
* Bump github.com/stretchr/testify from 1.9.0 to 1.10.0
([#1932](#1932)).
* Bump github.com/databricks/databricks-sdk-go from 0.51.0 to 0.52.0
([#1931](#1931)).
github-merge-queue bot pushed a commit that referenced this pull request Dec 5, 2024
## Changes

The `any` alias for `interface{}` has been around since Go 1.18.

Now that we're using golangci-lint (#1953), we can lint on it.

Existing commits can be updated with:
```
gofmt -w -r 'interface{} -> any' .
```

## Tests

n/a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants