Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move bulk of "golden tests" logic to libs/testdiff #2054

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

denik
Copy link
Contributor

@denik denik commented Dec 30, 2024

Changes

  • Detach "golden files" assertions from testcli runner. Now any output can be compared, no matter how it is obtained.
  • Move those assertion to libs/testdiff package.

This allows using "golden files" in non-integration tests.

Tests

Existing tests

This makes it available to non-integration tests as well.
@denik denik temporarily deployed to test-trigger-is December 30, 2024 14:18 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is December 30, 2024 14:18 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is December 30, 2024 14:54 — with GitHub Actions Inactive
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/cli

Inputs:

  • PR number: 2054
  • Commit SHA: e9f50ea7bf95b4a2ab07b566fdb836cf043f51a5

Checks will be approved automatically on success.

@denik denik temporarily deployed to test-trigger-is December 30, 2024 14:54 — with GitHub Actions Inactive
@denik denik marked this pull request as ready for review December 30, 2024 15:11
@denik denik added this pull request to the merge queue Dec 30, 2024
Merged via the queue into main with commit 261b7f4 Dec 30, 2024
9 checks passed
@denik denik deleted the denik/refactor-golden-test branch December 30, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants