fix: gcp_service_account_key is not available #910
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GcpServiceAccountKey
doesn't exist onStorageCredentialInfo
in thecurrent SDKs
I ran across this when using AWS backed accounts:
Because of the way OpenAPI changes are applied to the source, I can't tell when this was broken (or if it ever worked).
Some 💡 ideas that might prevent problems in the future.
git diff
andgit blame
remain useful.{{If}}
in templates; they can hide problems like this. If this were a single method that returned a string, then this would have been caught at compile time instead of run time.