Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gcp_service_account_key is not available #910

Closed
wants to merge 1 commit into from

Conversation

docwhat
Copy link

@docwhat docwhat commented Oct 23, 2023

GcpServiceAccountKey doesn't exist on StorageCredentialInfo in the
current SDKs

I ran across this when using AWS backed accounts:

❯ databricks storage-credentials list
Error: template: command:2:169: executing "command" at <.GcpServiceAccountKey>: can't evaluate field GcpServiceAccountKey in type catalog.StorageCredentialInfo

Because of the way OpenAPI changes are applied to the source, I can't tell when this was broken (or if it ever worked).

Some 💡 ideas that might prevent problems in the future.

  1. Ensure that OpenAPI updates apply in a way that lets git diff and git blame remain useful.
  2. Have the template be tested against a mock of the OpenAPI object(s) to ensure it doesn't break.
  3. Don't use {{If}} in templates; they can hide problems like this. If this were a single method that returned a string, then this would have been caught at compile time instead of run time.

@andrewnester andrewnester self-requested a review October 24, 2023 16:03
@andrewnester andrewnester linked an issue Nov 30, 2023 that may be closed by this pull request
GcpServiceAccountKey doesn't exist on StorageCredentialInfo in the
current SDKs
@docwhat docwhat force-pushed the gcp_service_account_key branch from 8122cc8 to b365981 Compare December 19, 2023 16:02
@docwhat
Copy link
Author

docwhat commented Dec 19, 2023

@nfx

I can't find any references to a CLA. If you provide information, I can see about signing it.

Since I am just deleting code, this cannot be copyrighted and, therefore, isn't worthy of a CLA.

If it somehow is copyrightable, then I declare commit b365981 to be in the public domain, freely used by anyone.

@andrewnester
Copy link
Contributor

Hi @docwhat !
We're working on adding correct CLA and processes.
Since we still want to keep GCP related information in template, there's another PR to address the issue: #1094

github-merge-queue bot pushed a commit that referenced this pull request Jan 2, 2024
## Changes
Fixes #1029 
Closes #910 

## Tests
Added regression test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"storage-credentials list" has a broken template
3 participants