Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase cluster creation test timeout #617

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

mgyucht
Copy link
Contributor

@mgyucht mgyucht commented Apr 16, 2024

Changes

Increase test timeout for cluster creation from 10m to 20m, as the time taken in GCP is close to 10 minutes.

Tests

  • make test run locally
  • make fmt applied
  • relevant integration tests applied

@mgyucht mgyucht requested a review from tanmay-db April 16, 2024 14:45
Copy link

This PR breaks backwards compatibility for databrickslabs/ucx downstream. See build logs for more details.

Running from downstreams #24

@mgyucht mgyucht added this pull request to the merge queue Apr 17, 2024
Merged via the queue into main with commit c2367af Apr 17, 2024
8 of 9 checks passed
@mgyucht mgyucht deleted the increase-cluster-creation-test-timeout branch April 17, 2024 07:42
tanmay-db added a commit that referenced this pull request Apr 24, 2024
* Increase cluster creation test timeout ([#617](#617)).
* Add code example for adding a user to a group using group patch API ([#625](#625)).
* Update SDK to OpenAPI spec ([#624](#624)).

API Changes:

 * Added `schema_id` field for `databricks.sdk.service.catalog.SchemaInfo`.
 * Removed `aws_operation` field for `databricks.sdk.service.catalog.ValidationResult`.
 * Removed `azure_operation` field for `databricks.sdk.service.catalog.ValidationResult`.
 * Removed `gcp_operation` field for `databricks.sdk.service.catalog.ValidationResult`.
 * Added `operation` field for `databricks.sdk.service.catalog.ValidationResult`.
 * Removed `databricks.sdk.service.catalog.ValidationResultAwsOperation` dataclass.
 * Removed `databricks.sdk.service.catalog.ValidationResultAzureOperation` dataclass.
 * Removed `databricks.sdk.service.catalog.ValidationResultGcpOperation` dataclass.
 * Added `databricks.sdk.service.catalog.ValidationResultOperation` dataclass.
 * Changed `cluster_status()` method for [w.libraries](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/libraries.html) workspace-level service . New request type is `databricks.sdk.service.compute.ClusterStatus` dataclass.
 * Changed `cluster_status()` method for [w.libraries](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/libraries.html) workspace-level service to return `databricks.sdk.service.compute.ClusterStatusResponse` dataclass.
 * Removed `databricks.sdk.service.compute.ClusterStatusRequest` dataclass.
 * Added `requirements` field for `databricks.sdk.service.compute.Library`.
 * Changed `status` field for `databricks.sdk.service.compute.LibraryFullStatus` to `databricks.sdk.service.compute.LibraryInstallStatus` dataclass.
 * Removed `databricks.sdk.service.compute.LibraryFullStatusStatus` dataclass.
 * Added `databricks.sdk.service.compute.ClusterStatus` dataclass.
 * Added `databricks.sdk.service.compute.ClusterStatusResponse` dataclass.
 * Added `databricks.sdk.service.compute.LibraryInstallStatus` dataclass.
 * Added `warehouse_id` field for `databricks.sdk.service.jobs.NotebookTask`.
 * Added `run_as` field for `databricks.sdk.service.jobs.SubmitRun`.
 * Added `deployment` field for `databricks.sdk.service.pipelines.CreatePipeline`.
 * Added `deployment` field for `databricks.sdk.service.pipelines.EditPipeline`.
 * Added `deployment` field for `databricks.sdk.service.pipelines.PipelineSpec`.
 * Added `databricks.sdk.service.pipelines.DeploymentKind` dataclass.
 * Added `databricks.sdk.service.pipelines.PipelineDeployment` dataclass.

OpenAPI SHA: 06d330f43d92c1be864d4638c672cd0723e20a51, Date: 2024-04-22
@tanmay-db tanmay-db mentioned this pull request Apr 24, 2024
github-merge-queue bot pushed a commit that referenced this pull request Apr 24, 2024
## 0.26.0

* Increase cluster creation test timeout
([#617](#617)).
* Added code example for adding a user to a group using group patch API
([#625](#625)).
* Updated SDK to OpenAPI spec
([#624](#624)).

Note: This release contains breaking changes, please see the API changes
below for more details.

API Changes:

* Added `deployment` field for
`databricks.sdk.service.pipelines.CreatePipeline`,
`databricks.sdk.service.pipelines.EditPipeline` and
`databricks.sdk.service.pipelines.PipelineSpec`.
* Added `schema_id` field for
`databricks.sdk.service.catalog.SchemaInfo`.
* Added `operation` field for
`databricks.sdk.service.catalog.ValidationResult`.
* Added `requirements` field for
`databricks.sdk.service.compute.Library`.
* Added `warehouse_id` field for
`databricks.sdk.service.jobs.NotebookTask`.
 * Added `run_as` field for `databricks.sdk.service.jobs.SubmitRun`.
* Added `databricks.sdk.service.catalog.ValidationResultOperation`
dataclass.
 * Added `databricks.sdk.service.compute.ClusterStatus` dataclass.
* Added `databricks.sdk.service.compute.ClusterStatusResponse`
dataclass.
* Added `databricks.sdk.service.compute.LibraryInstallStatus` dataclass.
 * Added `databricks.sdk.service.pipelines.DeploymentKind` dataclass.
* Added `databricks.sdk.service.pipelines.PipelineDeployment` dataclass.
* Removed `aws_operation` field for
`databricks.sdk.service.catalog.ValidationResult`.
* Removed `azure_operation` field for
`databricks.sdk.service.catalog.ValidationResult`.
* Removed `gcp_operation` field for
`databricks.sdk.service.catalog.ValidationResult`.
* Removed `databricks.sdk.service.catalog.ValidationResultAwsOperation`
dataclass.
* Removed
`databricks.sdk.service.catalog.ValidationResultAzureOperation`
dataclass.
* Removed `databricks.sdk.service.catalog.ValidationResultGcpOperation`
dataclass.
* Removed `databricks.sdk.service.compute.LibraryFullStatusStatus`
dataclass.
* Removed `databricks.sdk.service.compute.ClusterStatusRequest`
dataclass.
* Changed `cluster_status()` method for
[w.libraries](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/libraries.html)
workspace-level service . New request type is
`databricks.sdk.service.compute.ClusterStatus` dataclass.
* Changed `cluster_status()` method for
[w.libraries](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/libraries.html)
workspace-level service to return
`databricks.sdk.service.compute.ClusterStatusResponse` dataclass.
* Changed `status` field for
`databricks.sdk.service.compute.LibraryFullStatus` to
`databricks.sdk.service.compute.LibraryInstallStatus` dataclass.

OpenAPI SHA: 06d330f43d92c1be864d4638c672cd0723e20a51, Date: 2024-04-22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants