Logging improvements #172
Merged
Logging improvements #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differentiated some cases where the logged messages were ambiguous as to which code path they came from. Updated client to be more consistent in what context information is included in logging messages. Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
rcypher-databricks
requested review from
susodapop,
yunbodeng-db,
andrefurlan-db and
jadewang-db
as code owners
Logging status/state returned by executing a statement. The logic for handling context cancel/timeout was not working correctly in the case where there are no direct results returned from execute statement. Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
jadewang-db
approved these changes
Oct 12, 2023
| logDisplayMessage(resp, log) | ||
| logExecStatementState(resp, log) | ||
|
|
||
| defer log.Duration(msg, start) |
There was a problem hiding this comment.
should we move this to before line 170?
Co-authored-by: Jesse <jwhitehouse@airpost.net> Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
rcypher-databricks
force-pushed
the
logging
branch
from
c52a621
to
3df5f70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differentiated some cases where the logged messages were ambiguous as to which code path they came from.
Updated client to be more consistent in what context information is included in logging messages. Also updated client methods to produce a duration log message even if there is an error. Updated error handling to log the wrapped error message.