Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "bundle sync" instead of "bundle deploy" for remote run commands #1401

Merged
merged 6 commits into from
Oct 24, 2024
Merged

Use "bundle sync" instead of "bundle deploy" for remote run commands #1401

merged 6 commits into from
Oct 24, 2024

Conversation

ilia-db
Copy link
Contributor

@ilia-db ilia-db commented Oct 22, 2024 •
edited
Loading

Changes

Also changes the continuous sync logic to use the bundle sync command instead of the sync.

Depends on the CLI PR: databricks/cli#1853

Sync E2E tests will be failing until we update the CLI

Tests

Manual and existing unit and e2e tests

@ilia-db
Use bundle sync instead of deploy before remote run commands
8814c7a 
Also changes Sync logic to use the bundle sync command.

Depends on the CLI PR: databricks/cli#1853
@ilia-db
Fix tests
ece4b34
@ilia-db ilia-db requested a review from fjakobs October 22, 2024 11:42
@ilia-db ilia-db changed the title Ilia db/sync before run Use "bundle sync" instead of "bundle deploy" for remote run commands Oct 22, 2024
@ilia-db ilia-db mentioned this pull request Oct 22, 2024
Merged
github-merge-queue bot pushed a commit to databricks/cli that referenced this pull request Oct 23, 2024
@ilia-db
Add "output" flag to the bundle sync command (#1853)
55a055d 
## Changes
We want to use 'bundle sync' in the vscode extension before running a
file as an ad-hoc job (or through the context api). Right now we use
bundle deploy in these cases, but deploying bundle resources is not
always expected when you just want to quickly run a file. Sync makes
more sense in these cases, but we still want to have verbose output to
see what's happening.

In the 'deploy' command we have hidden 'verbose' flag. For the sync I've
just added 'output' flag, handling both json and text cases, similar to
how it's done in the non-bundle `sync` command. The flag is not hidden
(although we still don't show any output by default, if the flag is not
set).

VSCode Extension PR:
databricks/databricks-vscode#1401


## Tests
Manually
@ilia-db ilia-db temporarily deployed to test-trigger-is October 24, 2024 09:19 — with GitHub Actions Inactive
@eng-dev-ecosystem-bot
Copy link
Collaborator

Test status: failure
Commit SHA: c6ab10d

@ilia-db ilia-db merged commit 7afb87f into bundle-integ Oct 24, 2024
28 of 29 checks passed
@ilia-db ilia-db deleted the ilia-db/sync-before-run branch October 24, 2024 09:31
@github-actions github-actions bot mentioned this pull request Oct 24, 2024
Merged
ilia-db added a commit that referenced this pull request Oct 24, 2024
@github-actions @web-flow @ilia-db
Release: v2.4.7 (#1408)
3e5dc49 
## packages/databricks-vscode
##  (2024-10-24)

* Add e2e tests for the deployment cancellation (#1396)
([94bf23b](94bf23b)),
closes
[#1396](#1396)
* Don't initialise spark progress widget if it's not supported (#1402)
([afe75eb](afe75eb)),
closes
[#1402](#1402)
* Fix CLI cancellation on windows (#1393)
([9c864af](9c864af)),
closes
[#1393](#1393)
* Improve environment setup UX (#1395)
([97daab1](97daab1)),
closes
[#1395](#1395)
* Improve profiles loading (#1398)
([95ab5c6](95ab5c6)),
closes
[#1398](#1398)
* Improve run button UX (#1397)
([c1c4a43](c1c4a43)),
closes
[#1397](#1397)
* Prevent welcome view flashes (#1399)
([261e06c](261e06c)),
closes
[#1399](#1399)
* Update the CLI to v0.231.0 (#1407)
([05114fa](05114fa)),
closes
[#1407](#1407)
* Use "bundle sync" instead of "bundle deploy" for remote run commands
(#1401)
([7afb87f](7afb87f)),
closes
[#1401](#1401)



## packages/databricks-vscode-types
##  (2024-10-24)

---------

Co-authored-by: releasebot <noreply@github.com>
Co-authored-by: Ilia Babanov <ilia.babanov@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjakobs fjakobs fjakobs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilia-db @eng-dev-ecosystem-bot @fjakobs