Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix image link to getting started guide #446

Merged
merged 3 commits into from
Feb 15, 2023
Merged

fix image link to getting started guide #446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e4b67e5
fix image links in README.md
fjakobs Feb 14, 2023
365b8d5
Update getting started animated gif
fjakobs Feb 15, 2023
ac99523
Merge branch 'main' into grooming
fjakobs Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/databricks-vscode/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,11 @@ In order to use this extension you need access to a Databricks workspace:
3. Access to an interactive cluster or permissions to create a cluster
4. Permissions to create Databricks Repos

## Documentation
## Getting started

![configure](./images/configure.gif)

Comment out until the repo is public so the image can be loaded by the marketplace
## Documentation

- The [Quick Start Guide](README.quickstart.md) provides an overview
of common features.
Expand Down
3 changes: 1 addition & 2 deletions packages/databricks-vscode/README.quickstart.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ The Databricks extension for VS Code allows you to develop for the Databricks La
1. You can also select the first entry in the list to create a new cluster. Selecting the item will take you into the Databricks web application.
2. We recommend creating a Personal Compute Cluster.
5. Click the "gear" icon in the Repo tree item to select a repo to sync code to
1. You can also select the first entry in the list to create a new Databricks repo. Selecting the item will take you into the Databricks web application.
2. We recommend to not configure a git remote for you repo and do all git operations from the IDE
1. You can also select the first entry in the list to create a new Databricks repo

![configure](./images/configure.gif)

Expand Down
Binary file modified packages/databricks-vscode/images/configure.gif
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions packages/databricks-vscode/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,7 @@
},
"scripts": {
"vscode:prepublish": "rm -rf out && yarn run package:compile && yarn run package:copy-webview-toolkit",
"package": "BASE_URL=https://raw.githubusercontent.com/databricks/databricks-vscode/${TAG:-main}/packages/databricks-vscode && vsce package --baseContentUrl $BASE_URL --baseImagesUrl $BASE_URL",
"package": "vsce package --baseContentUrl https://github.com/databricks/databricks-vscode/blob/${TAG:-main}/packages/databricks-vscode --baseImagesUrl https://raw.githubusercontent.com/databricks/databricks-vscode/${TAG:-main}/packages/databricks-vscode",
"package:cli:fetch": "BRICKS_VERSION=0.0.21 && bash ./scripts/fetch-bricks-cli.sh ${BRICKS_VERSION} ${BRICKS_ARCH:-}",
"package:cli:link": "rm -f ./bin/bricks && ln -s ../../../../bricks/bricks bin",
"package:compile": "yarn run esbuild:base",
Expand Down Expand Up @@ -707,4 +707,4 @@
],
"report-dir": "coverage"
}
}
}