Non-flattening MongoDb Debezium SMT #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds debezium mongo SMT for converting BSON before/after into typed Struct before/after
...t-transforms/src/main/java/io/tabular/iceberg/connect/transforms/MongoDebeziumTransform.java
Outdated
Show resolved
Hide resolved
...ct-transforms/src/main/java/io/debezium/connector/mongodb/transforms/MongoDataConverter.java
Show resolved
Hide resolved
...t-transforms/src/main/java/io/tabular/iceberg/connect/transforms/MongoDebeziumTransform.java
Outdated
Show resolved
Hide resolved
fqtab
reviewed
Apr 16, 2024
There was a problem hiding this comment.
Not sure I can add much value here (very limited experience with MongoDB)
Some minor comments (I focused on the MongoDebeziumTransform class only, the rest looks like copy-paste from Debezium).
Let me know if there's anything specific you wanted me to look at, otherwise it's a LGTM from my side.
...t-transforms/src/main/java/io/tabular/iceberg/connect/transforms/MongoDebeziumTransform.java
Outdated
Show resolved
Hide resolved
...t-transforms/src/main/java/io/tabular/iceberg/connect/transforms/MongoDebeziumTransform.java
Outdated
Show resolved
Hide resolved
...t-transforms/src/main/java/io/tabular/iceberg/connect/transforms/MongoDebeziumTransform.java
Outdated
Show resolved
Hide resolved
...t-transforms/src/main/java/io/tabular/iceberg/connect/transforms/MongoDebeziumTransform.java
Outdated
Show resolved
Hide resolved
...t-transforms/src/main/java/io/tabular/iceberg/connect/transforms/MongoDebeziumTransform.java
Outdated
Show resolved
Hide resolved
...t-transforms/src/main/java/io/tabular/iceberg/connect/transforms/MongoDebeziumTransform.java
Outdated
Show resolved
Hide resolved
fqtab
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does not address mongoDB columns with invalid characters (in a given catalog), which will be addressed in a later PR.