Do not allow duplicate field in object when evaluating list list comprehension #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edsilfer
requested review from
szeiger,
lihaoyi,
iuliand-db,
samk-db and
apattidb
edsilfer
force-pushed
the
edgar/fix-duplicate-field-on-list-comprehension
branch
from
230693f
to
5259355
Compare
lihaoyi-databricks
approved these changes
Nov 9, 2020
edsilfer
force-pushed
the
edgar/fix-duplicate-field-on-list-comprehension
branch
from
5259355
to
a893c6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR fixes issue 99 by issuing an error in case an
Expr.Stris matching with anExpr.ForSpecwith a value greater than 1. This condition denotes that theExpr.Strfield value would be overridden in each interaction of theExpr.ForSpecHow is this tested?
./mill "sjsonnet[2.13.3].jvm.test.testLocal"to make sure that all the tests are still passing