Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse arbitrary exprs after "import" and "importStr" #153

Merged
merged 3 commits into from
May 31, 2023

Conversation

szeiger
Copy link
Collaborator

@szeiger szeiger commented Sep 1, 2022

Fixes #138

The spec is not very clear on this but this behavior is consistent with the C++ and Go implementations.

Fixes databricks#138

The spec is not very clear on this but this behavior is consistent with the C++ and Go implementations.
@nicklan
Copy link
Contributor

nicklan commented Dec 1, 2022

Is this still something you want to merge? Also, will this catch cases like:

local default = import "foo.jsonnet".DEFAULT;

@lihaoyi-databricks lihaoyi-databricks merged commit 7504e1a into databricks:master May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sjsonnet allows computed imports unlike go-jsonnet
3 participants