Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a column to $inventory.tables to specify if a table might have been synchronised to Unity Catalog already or not #306

Merged
merged 17 commits into from
Oct 3, 2023

Conversation

FastLee
Copy link
Contributor

@FastLee FastLee commented Sep 27, 2023

Closes #303

@FastLee FastLee added the pr/do-not-merge this pull request is not ready to merge label Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #306 (765c43d) into main (e516998) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
+ Coverage   83.40%   83.46%   +0.05%     
==========================================
  Files          30       30              
  Lines        2308     2316       +8     
  Branches      409      409              
==========================================
+ Hits         1925     1933       +8     
  Misses        295      295              
  Partials       88       88              
Files Coverage Δ
src/databricks/labs/ucx/hive_metastore/tables.py 94.65% <100.00%> (+0.34%) ⬆️

@nfx nfx added invalid This doesn't seem right wontfix This will not be worked on and removed pr/do-not-merge this pull request is not ready to merge labels Sep 27, 2023
@FastLee FastLee added enhancement New feature or request and removed invalid This doesn't seem right wontfix This will not be worked on labels Sep 27, 2023
@nfx nfx added pr/do-not-merge this pull request is not ready to merge and removed enhancement New feature or request labels Sep 27, 2023
@FastLee FastLee added the enhancement New feature or request label Sep 29, 2023
Copy link
Contributor

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase on main - you're deleting features.

src/databricks/labs/ucx/framework/dashboards.py Outdated Show resolved Hide resolved
@FastLee FastLee requested a review from nfx October 2, 2023 13:53
@nfx nfx added this to the 1 week milestone Oct 2, 2023
@zpappa zpappa removed this from the 1 week milestone Oct 2, 2023
@FastLee
Copy link
Contributor Author

FastLee commented Oct 2, 2023

I fixed the rebase. Please review

src/databricks/labs/ucx/hive_metastore/tables.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/hive_metastore/tables.scala Outdated Show resolved Hide resolved
@FastLee FastLee requested a review from nfx October 2, 2023 18:30
src/databricks/labs/ucx/hive_metastore/tables.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/hive_metastore/tables.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/hive_metastore/tables.scala Outdated Show resolved Hide resolved
@FastLee FastLee requested a review from nfx October 3, 2023 16:46
@nfx nfx changed the title Feature/table update status Added a column to $inventory.tables to specify if a table might have been synchronised to Unity Catalog already or not Oct 3, 2023
@FastLee FastLee force-pushed the feature/table_update_status branch from 282eb80 to 82c0327 Compare October 3, 2023 19:33
@nfx nfx added this pull request to the merge queue Oct 3, 2023
Merged via the queue into main with commit 0bf43e7 Oct 3, 2023
5 checks passed
nfx added a commit that referenced this pull request Oct 3, 2023
* Added `inventory_database` name check during installation ([#275](#275)).
* Added a column to `$inventory.tables` to specify if a table might have been synchronised to Unity Catalog already or not ([#306](#306)).
* Added a migration state to skip already migrated tables ([#325](#325)).
* Fixed appending to tables by adding filtering of `None` rows ([#356](#356)).
* Fixed handling of missing but linked cluster policies. ([#361](#361)).
* Ignore errors for Redash widgets and queries redeployment during installation ([#367](#367)).
* Remove exception and added proper logging for groups in the list that… ([#357](#357)).
* Skip group migration when no groups are available after preparation step. ([#363](#363)).
* Update databricks-sdk requirement from ~=0.9.0 to ~=0.10.0 ([#362](#362)).
@nfx nfx mentioned this pull request Oct 3, 2023
nfx added a commit that referenced this pull request Oct 3, 2023
* Added `inventory_database` name check during installation
([#275](#275)).
* Added a column to `$inventory.tables` to specify if a table might have
been synchronised to Unity Catalog already or not
([#306](#306)).
* Added a migration state to skip already migrated tables
([#325](#325)).
* Fixed appending to tables by adding filtering of `None` rows
([#356](#356)).
* Fixed handling of missing but linked cluster policies.
([#361](#361)).
* Ignore errors for Redash widgets and queries redeployment during
installation ([#367](#367)).
* Remove exception and added proper logging for groups in the list that…
([#357](#357)).
* Skip group migration when no groups are available after preparation
step. ([#363](#363)).
* Update databricks-sdk requirement from ~=0.9.0 to ~=0.10.0
([#362](#362)).
zpappa pushed a commit that referenced this pull request Oct 4, 2023
…e been synchronised to Unity Catalog already or not (#306)

Closes #303
zpappa pushed a commit that referenced this pull request Oct 4, 2023
* Added `inventory_database` name check during installation
([#275](#275)).
* Added a column to `$inventory.tables` to specify if a table might have
been synchronised to Unity Catalog already or not
([#306](#306)).
* Added a migration state to skip already migrated tables
([#325](#325)).
* Fixed appending to tables by adding filtering of `None` rows
([#356](#356)).
* Fixed handling of missing but linked cluster policies.
([#361](#361)).
* Ignore errors for Redash widgets and queries redeployment during
installation ([#367](#367)).
* Remove exception and added proper logging for groups in the list that…
([#357](#357)).
* Skip group migration when no groups are available after preparation
step. ([#363](#363)).
* Update databricks-sdk requirement from ~=0.9.0 to ~=0.10.0
([#362](#362)).
@nfx nfx deleted the feature/table_update_status branch October 17, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pr/do-not-merge this pull request is not ready to merge
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add upgrade status and upgrade target to the "tables" assessment table
3 participants