Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip group migration when no groups are available after preparation step. #363

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Skip group migration when no groups are available after preparation step. #363

merged 2 commits into from
Oct 3, 2023

Conversation

larsgeorge-db
Copy link
Contributor

Fixes #360

@larsgeorge-db larsgeorge-db self-assigned this Oct 3, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #363 (c2be2f9) into main (f3886f7) will decrease coverage by 0.12%.
Report is 1 commits behind head on main.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
- Coverage   83.58%   83.47%   -0.12%     
==========================================
  Files          30       30              
  Lines        2254     2269      +15     
  Branches      394      395       +1     
==========================================
+ Hits         1884     1894      +10     
- Misses        285      290       +5     
  Partials       85       85
Files Coverage Δ
src/databricks/labs/ucx/workspace_access/groups.py 93.12% <100.00%> (+0.10%) ⬆️
.../databricks/labs/ucx/workspace_access/migration.py 47.76% <50.00%> (+0.06%) ⬆️
src/databricks/labs/ucx/runtime.py 54.79% <0.00%> (-1.55%) ⬇️

... and 1 file with indirect coverage changes

@nfx nfx added this pull request to the merge queue Oct 3, 2023
Merged via the queue into main with commit 035320c Oct 3, 2023
3 of 5 checks passed
zpappa pushed a commit that referenced this pull request Oct 3, 2023
@larsgeorge-db @zpappa
Skip group migration when no groups are available after preparation s…
ea1707b 
…tep. (#363)

Fixes #360
nfx added a commit that referenced this pull request Oct 3, 2023
@nfx
Release v0.3.0
d19af3c 
* Added `inventory_database` name check during installation ([#275](#275)).
* Added a column to `$inventory.tables` to specify if a table might have been synchronised to Unity Catalog already or not ([#306](#306)).
* Added a migration state to skip already migrated tables ([#325](#325)).
* Fixed appending to tables by adding filtering of `None` rows ([#356](#356)).
* Fixed handling of missing but linked cluster policies. ([#361](#361)).
* Ignore errors for Redash widgets and queries redeployment during installation ([#367](#367)).
* Remove exception and added proper logging for groups in the list that… ([#357](#357)).
* Skip group migration when no groups are available after preparation step. ([#363](#363)).
* Update databricks-sdk requirement from ~=0.9.0 to ~=0.10.0 ([#362](#362)).
@nfx nfx mentioned this pull request Oct 3, 2023
Merged
nfx added a commit that referenced this pull request Oct 3, 2023
@nfx
Release v0.3.0 (#369)
b464807 
* Added `inventory_database` name check during installation
([#275](#275)).
* Added a column to `$inventory.tables` to specify if a table might have
been synchronised to Unity Catalog already or not
([#306](#306)).
* Added a migration state to skip already migrated tables
([#325](#325)).
* Fixed appending to tables by adding filtering of `None` rows
([#356](#356)).
* Fixed handling of missing but linked cluster policies.
([#361](#361)).
* Ignore errors for Redash widgets and queries redeployment during
installation ([#367](#367)).
* Remove exception and added proper logging for groups in the list that…
([#357](#357)).
* Skip group migration when no groups are available after preparation
step. ([#363](#363)).
* Update databricks-sdk requirement from ~=0.9.0 to ~=0.10.0
([#362](#362)).
zpappa pushed a commit that referenced this pull request Oct 4, 2023
@nfx @zpappa
Release v0.3.0 (#369)
35e9d70 
* Added `inventory_database` name check during installation
([#275](#275)).
* Added a column to `$inventory.tables` to specify if a table might have
been synchronised to Unity Catalog already or not
([#306](#306)).
* Added a migration state to skip already migrated tables
([#325](#325)).
* Fixed appending to tables by adding filtering of `None` rows
([#356](#356)).
* Fixed handling of missing but linked cluster policies.
([#361](#361)).
* Ignore errors for Redash widgets and queries redeployment during
installation ([#367](#367)).
* Remove exception and added proper logging for groups in the list that…
([#357](#357)).
* Skip group migration when no groups are available after preparation
step. ([#363](#363)).
* Update databricks-sdk requirement from ~=0.9.0 to ~=0.10.0
([#362](#362)).
@nfx nfx deleted the fix/issue_360_skip_empty_groups branch October 17, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfx nfx nfx approved these changes

Assignees

@larsgeorge-db larsgeorge-db

Labels
None yet
Projects
UCX (roadmap)
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The tool fails if there are no groups to migrate
2 participants
@larsgeorge-db @nfx