Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore errors for Redash widgets and queries redeployment during installation #367

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

FastLee
Copy link
Contributor

@FastLee FastLee commented Oct 3, 2023

Closes #347 #329

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #367 (9d33886) into main (035320c) will decrease coverage by 0.17%.
Report is 3 commits behind head on main.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #367      +/-   ##
==========================================
- Coverage   83.47%   83.31%   -0.17%     
==========================================
  Files          30       30              
  Lines        2269     2313      +44     
  Branches      395      409      +14     
==========================================
+ Hits         1894     1927      +33     
- Misses        290      298       +8     
- Partials       85       88       +3     
Files Coverage Δ
src/databricks/labs/ucx/framework/dashboards.py 75.98% <33.33%> (-0.91%) ⬇️

... and 3 files with indirect coverage changes

@nfx nfx changed the title Fix/install upgrade issues Ignore errors for Redash widgets and queries redeployment during installation Oct 3, 2023
@nfx nfx added this pull request to the merge queue Oct 3, 2023
Merged via the queue into main with commit ae59e49 Oct 3, 2023
3 of 5 checks passed
nfx added a commit that referenced this pull request Oct 3, 2023
* Added `inventory_database` name check during installation ([#275](#275)).
* Added a column to `$inventory.tables` to specify if a table might have been synchronised to Unity Catalog already or not ([#306](#306)).
* Added a migration state to skip already migrated tables ([#325](#325)).
* Fixed appending to tables by adding filtering of `None` rows ([#356](#356)).
* Fixed handling of missing but linked cluster policies. ([#361](#361)).
* Ignore errors for Redash widgets and queries redeployment during installation ([#367](#367)).
* Remove exception and added proper logging for groups in the list that… ([#357](#357)).
* Skip group migration when no groups are available after preparation step. ([#363](#363)).
* Update databricks-sdk requirement from ~=0.9.0 to ~=0.10.0 ([#362](#362)).
@nfx nfx mentioned this pull request Oct 3, 2023
nfx added a commit that referenced this pull request Oct 3, 2023
* Added `inventory_database` name check during installation
([#275](#275)).
* Added a column to `$inventory.tables` to specify if a table might have
been synchronised to Unity Catalog already or not
([#306](#306)).
* Added a migration state to skip already migrated tables
([#325](#325)).
* Fixed appending to tables by adding filtering of `None` rows
([#356](#356)).
* Fixed handling of missing but linked cluster policies.
([#361](#361)).
* Ignore errors for Redash widgets and queries redeployment during
installation ([#367](#367)).
* Remove exception and added proper logging for groups in the list that…
([#357](#357)).
* Skip group migration when no groups are available after preparation
step. ([#363](#363)).
* Update databricks-sdk requirement from ~=0.9.0 to ~=0.10.0
([#362](#362)).
zpappa pushed a commit that referenced this pull request Oct 4, 2023
zpappa pushed a commit that referenced this pull request Oct 4, 2023
* Added `inventory_database` name check during installation
([#275](#275)).
* Added a column to `$inventory.tables` to specify if a table might have
been synchronised to Unity Catalog already or not
([#306](#306)).
* Added a migration state to skip already migrated tables
([#325](#325)).
* Fixed appending to tables by adding filtering of `None` rows
([#356](#356)).
* Fixed handling of missing but linked cluster policies.
([#361](#361)).
* Ignore errors for Redash widgets and queries redeployment during
installation ([#367](#367)).
* Remove exception and added proper logging for groups in the list that…
([#357](#357)).
* Skip group migration when no groups are available after preparation
step. ([#363](#363)).
* Update databricks-sdk requirement from ~=0.9.0 to ~=0.10.0
([#362](#362)).
@nfx nfx deleted the fix/install_upgrade_issues branch October 17, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Upgrade Fails with "Asset is already in trash"
2 participants