Update WorkspaceClient to support globbing
#125
Merged
+423
−173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ 17/18 passed, 1 failed, 2 skipped, 32s total ❌ test_mkdirs: TypeError: can only concatenate list (not "method") to list (4ms)Running from acceptance #175 |
nfx
approved these changes
Jul 12, 2024
|
|
||
| def glob(self, pattern, *, case_sensitive=None): | ||
| pattern_parts = self._prepare_pattern(pattern) | ||
| selector = _Selector.parse(pattern_parts, case_sensitive=case_sensitive if case_sensitive is not None else True) |
There was a problem hiding this comment.
Suggested change
| selector = _Selector.parse(pattern_parts, case_sensitive=case_sensitive if case_sensitive is not None else True) | |
| case_sensitive = case_sensitive if case_sensitive is not None else True | |
| selector = _Selector.parse(pattern_parts, case_sensitive=case_sensitive) |
|
|
||
| def rglob(self, pattern, *, case_sensitive=None): | ||
| pattern_parts = ("**", *self._prepare_pattern(pattern)) | ||
| selector = _Selector.parse(pattern_parts, case_sensitive=case_sensitive if case_sensitive is not None else True) |
There was a problem hiding this comment.
Suggested change
| selector = _Selector.parse(pattern_parts, case_sensitive=case_sensitive if case_sensitive is not None else True) | |
| case_sensitive = case_sensitive if case_sensitive is not None else True | |
| selector = _Selector.parse(pattern_parts, case_sensitive=case_sensitive) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is stacked on top of #122 and updates
WorkspaceClientto support:.glob().rglob().iterdir()