Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed py3.10 compatibility for _parts in pathlike #135

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Fixed py3.10 compatibility for _parts in pathlike #135

merged 1 commit into from
Jul 16, 2024

Conversation

nfx
Copy link
Collaborator

@nfx nfx commented Jul 16, 2024

No description provided.

Copy link

✅ 31/31 passed, 2 skipped, 1m9s total

Running from acceptance #201

@nfx nfx merged commit 821bc0a into main Jul 16, 2024
9 checks passed
@nfx nfx deleted the fix/_paths branch July 16, 2024 18:10
nfx added a commit that referenced this pull request Jul 16, 2024
* Fixed py3.10 compatibility for `_parts` in pathlike ([#135](#135)). The recent update to our open-source library addresses the compatibility issue with Python 3.10 in the `_parts` property of a certain type. Prior to this change, there was also a `_cparts` property that returned the same value as `_parts`, which has been removed and replaced with a direct reference to `_parts`. The `_parts` property can now be accessed via reverse equality comparison, and this change has been implemented in the `joinpath` and `__truediv__` methods as well. This enhancement improves the library's compatibility with Python 3.10 and beyond, ensuring continued functionality and stability for software engineers working with the latest Python versions.
@nfx nfx mentioned this pull request Jul 16, 2024
nfx added a commit that referenced this pull request Jul 16, 2024
* Fixed py3.10 compatibility for `_parts` in pathlike
([#135](#135)). The
recent update to our open-source library addresses the compatibility
issue with Python 3.10 in the `_parts` property of a certain type. Prior
to this change, there was also a `_cparts` property that returned the
same value as `_parts`, which has been removed and replaced with a
direct reference to `_parts`. The `_parts` property can now be accessed
via reverse equality comparison, and this change has been implemented in
the `joinpath` and `__truediv__` methods as well. This enhancement
improves the library's compatibility with Python 3.10 and beyond,
ensuring continued functionality and stability for software engineers
working with the latest Python versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant