add missing stat() methods to DBFSPath and WorkspacePath #144

ericvergnaud · 2024-09-10T15:27:17Z

github-actions · 2024-09-10T15:28:29Z

❌ 38/40 passed, 2 failed, 1m30s total

❌ test_detect_global: AttributeError: 'PermissionDenied' object has no attribute 'message' (754ms)

AttributeError: 'PermissionDenied' object has no attribute 'message'
10:26 DEBUG [databricks.sdk] Loaded from environment
10:26 DEBUG [databricks.sdk] Ignoring pat auth, because metadata-service is preferred
10:26 DEBUG [databricks.sdk] Ignoring basic auth, because metadata-service is preferred
10:26 DEBUG [databricks.sdk] Attempting to configure auth: metadata-service
10:26 INFO [databricks.sdk] Using Databricks Metadata Service authentication
[gw1] linux -- Python 3.10.14 /home/runner/work/blueprint/blueprint/.venv/bin/python
10:26 DEBUG [databricks.sdk] Loaded from environment
10:26 DEBUG [databricks.sdk] Ignoring pat auth, because metadata-service is preferred
10:26 DEBUG [databricks.sdk] Ignoring basic auth, because metadata-service is preferred
10:26 DEBUG [databricks.sdk] Attempting to configure auth: metadata-service
10:26 INFO [databricks.sdk] Using Databricks Metadata Service authentication
10:26 DEBUG [databricks.labs.blueprint.installation] Uploading: /Applications/Ung4/some
10:26 DEBUG [databricks.sdk] POST /api/2.0/workspace/import
> [raw stream]
< 404 Not Found
< {
<   "error_code": "RESOURCE_DOES_NOT_EXIST",
<   "message": "The parent folder (/Applications/Ung4) does not exist."
< }
10:26 DEBUG [databricks.labs.blueprint.installation] Creating missing folders: /Applications/Ung4
10:26 DEBUG [databricks.sdk] POST /api/2.0/workspace/mkdirs
> {
>   "path": "/Applications/Ung4"
> }
< 403 Forbidden
< {
<   "error_code": "PERMISSION_DENIED",
<   "message": "4106dc97-a963-48f0-a079-a578238959a6 does not have View permissions on 0. Please contact the own... (34 more bytes)"
< }
10:26 DEBUG [databricks.sdk] Loaded from environment
10:26 DEBUG [databricks.sdk] Ignoring pat auth, because metadata-service is preferred
10:26 DEBUG [databricks.sdk] Ignoring basic auth, because metadata-service is preferred
10:26 DEBUG [databricks.sdk] Attempting to configure auth: metadata-service
10:26 INFO [databricks.sdk] Using Databricks Metadata Service authentication
10:26 DEBUG [databricks.labs.blueprint.installation] Uploading: /Applications/Ung4/some
10:26 DEBUG [databricks.sdk] POST /api/2.0/workspace/import
> [raw stream]
< 404 Not Found
< {
<   "error_code": "RESOURCE_DOES_NOT_EXIST",
<   "message": "The parent folder (/Applications/Ung4) does not exist."
< }
10:26 DEBUG [databricks.labs.blueprint.installation] Creating missing folders: /Applications/Ung4
10:26 DEBUG [databricks.sdk] POST /api/2.0/workspace/mkdirs
> {
>   "path": "/Applications/Ung4"
> }
< 403 Forbidden
< {
<   "error_code": "PERMISSION_DENIED",
<   "message": "4106dc97-a963-48f0-a079-a578238959a6 does not have View permissions on 0. Please contact the own... (34 more bytes)"
< }
[gw1] linux -- Python 3.10.14 /home/runner/work/blueprint/blueprint/.venv/bin/python

❌ test_existing_installations_are_detected: AttributeError: 'PermissionDenied' object has no attribute 'message' (303ms)

AttributeError: 'PermissionDenied' object has no attribute 'message'
10:26 DEBUG [databricks.sdk] Loaded from environment
10:26 DEBUG [databricks.sdk] Ignoring pat auth, because metadata-service is preferred
10:26 DEBUG [databricks.sdk] Ignoring basic auth, because metadata-service is preferred
10:26 DEBUG [databricks.sdk] Attempting to configure auth: metadata-service
10:26 INFO [databricks.sdk] Using Databricks Metadata Service authentication
[gw1] linux -- Python 3.10.14 /home/runner/work/blueprint/blueprint/.venv/bin/python
10:26 DEBUG [databricks.sdk] Loaded from environment
10:26 DEBUG [databricks.sdk] Ignoring pat auth, because metadata-service is preferred
10:26 DEBUG [databricks.sdk] Ignoring basic auth, because metadata-service is preferred
10:26 DEBUG [databricks.sdk] Attempting to configure auth: metadata-service
10:26 INFO [databricks.sdk] Using Databricks Metadata Service authentication
10:26 DEBUG [databricks.labs.blueprint.installation] Uploading: /Applications/pgob/some
10:26 DEBUG [databricks.sdk] POST /api/2.0/workspace/import
> [raw stream]
< 404 Not Found
< {
<   "error_code": "RESOURCE_DOES_NOT_EXIST",
<   "message": "The parent folder (/Applications/pgob) does not exist."
< }
10:26 DEBUG [databricks.labs.blueprint.installation] Creating missing folders: /Applications/pgob
10:26 DEBUG [databricks.sdk] POST /api/2.0/workspace/mkdirs
> {
>   "path": "/Applications/pgob"
> }
< 403 Forbidden
< {
<   "error_code": "PERMISSION_DENIED",
<   "message": "4106dc97-a963-48f0-a079-a578238959a6 does not have View permissions on 0. Please contact the own... (34 more bytes)"
< }
10:26 DEBUG [databricks.sdk] Loaded from environment
10:26 DEBUG [databricks.sdk] Ignoring pat auth, because metadata-service is preferred
10:26 DEBUG [databricks.sdk] Ignoring basic auth, because metadata-service is preferred
10:26 DEBUG [databricks.sdk] Attempting to configure auth: metadata-service
10:26 INFO [databricks.sdk] Using Databricks Metadata Service authentication
10:26 DEBUG [databricks.labs.blueprint.installation] Uploading: /Applications/pgob/some
10:26 DEBUG [databricks.sdk] POST /api/2.0/workspace/import
> [raw stream]
< 404 Not Found
< {
<   "error_code": "RESOURCE_DOES_NOT_EXIST",
<   "message": "The parent folder (/Applications/pgob) does not exist."
< }
10:26 DEBUG [databricks.labs.blueprint.installation] Creating missing folders: /Applications/pgob
10:26 DEBUG [databricks.sdk] POST /api/2.0/workspace/mkdirs
> {
>   "path": "/Applications/pgob"
> }
< 403 Forbidden
< {
<   "error_code": "PERMISSION_DENIED",
<   "message": "4106dc97-a963-48f0-a079-a578238959a6 does not have View permissions on 0. Please contact the own... (34 more bytes)"
< }
[gw1] linux -- Python 3.10.14 /home/runner/work/blueprint/blueprint/.venv/bin/python

_{Running from acceptance #211}

ericvergnaud · 2024-09-11T11:22:33Z

@nfx the no-cheat is about avoiding pylint errors in existing code
not sure what's causing the acceptance failure. The 2 failing tests pass locally, both are marked PermissionDenied. Smells like our test infra (sandbox?) expecting a message field ?

nfx

lgtm

* add missing stat() methods to DBFSPath and WorkspacePath ([#144](#144)). The `stat()` method has been added to both `DBFSPath` and `WorkspacePath` classes, addressing issues [#142](#142) and [#143](#143). This method, which adheres to the Posix standard, returns file status in the `os.stat_result` format, providing access to various metadata attributes such as file size, last modification time, and creation time. By incorporating this method, developers can now obtain essential file information for Databricks File System (DBFS) and Databricks Workspace paths when working with these classes. The change includes a new test case for `stat()` in the `test_paths.py` file to ensure the correctness of the method for both classes.

add missing stat() methods

19fc07b

ericvergnaud requested a review from nfx as a code owner September 10, 2024 15:27

ericvergnaud had a problem deploying to runtime September 10, 2024 15:27 — with GitHub Actions Failure

ericvergnaud had a problem deploying to runtime September 11, 2024 11:08 — with GitHub Actions Failure

align with unix conventions

fef621b

ericvergnaud had a problem deploying to runtime September 12, 2024 10:12 — with GitHub Actions Failure

align with unix conventions

785bb9a

ericvergnaud had a problem deploying to runtime September 12, 2024 10:25 — with GitHub Actions Failure

ericvergnaud mentioned this pull request Sep 13, 2024

Added storage for direct filesystem references in code databrickslabs/ucx#2526

Merged

4 tasks

nfx approved these changes Sep 13, 2024

View reviewed changes

nfx merged commit 36fc873 into main Sep 13, 2024
7 of 9 checks passed

nfx deleted the fix-missing-stat-methods branch September 13, 2024 17:11

nfx mentioned this pull request Sep 13, 2024

Release v0.8.3 #145

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add missing stat() methods to DBFSPath and WorkspacePath #144

add missing stat() methods to DBFSPath and WorkspacePath #144

ericvergnaud commented Sep 10, 2024

github-actions bot commented Sep 10, 2024 •

edited

Loading

ericvergnaud commented Sep 11, 2024

nfx left a comment

add missing stat() methods to DBFSPath and WorkspacePath #144

add missing stat() methods to DBFSPath and WorkspacePath #144

Conversation

ericvergnaud commented Sep 10, 2024

github-actions bot commented Sep 10, 2024 • edited Loading

ericvergnaud commented Sep 11, 2024

nfx left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 10, 2024 •

edited

Loading