Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pylint issues on main #167

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Fix pylint issues on main #167

merged 1 commit into from
Nov 8, 2024

Conversation

asnare
Copy link
Contributor

@asnare asnare commented Nov 7, 2024

At present main does not pass the formatting and linting checks; this PR fixes this.

@asnare asnare added the internal do not show this PR in changelog label Nov 7, 2024
@asnare asnare self-assigned this Nov 7, 2024
@asnare asnare requested a review from nfx as a code owner November 7, 2024 16:59
Copy link

github-actions bot commented Nov 7, 2024

✅ 40/40 passed, 2 skipped, 1m50s total

Running from acceptance #231

Copy link
Collaborator

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nfx nfx merged commit 2b09928 into main Nov 8, 2024
9 checks passed
@nfx nfx deleted the fix-lint branch November 8, 2024 10:50
nfx pushed a commit that referenced this pull request Nov 8, 2024
This pull request updates the project so that all tests pass with python
3.13. Changes include:

- ~Refactoring the `paths` module into a few submodules. This is a
source-compatible change that is not intended to introduce any
behavioural changes.~
- Adding in the new ~`databrickspath`~`_posixpath` submodule, so that
`PosixPath` can be treated as distinct from `DBFSPath` and
`WorkspacePath`.
 - Marking the project as supporting python 3.13.
 - Including python 3.13 in the build/CI version matrix.

~An incidental linting error was also fixed.~(Now on #167.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal do not show this PR in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants