Skip to content

Commit

Permalink
Fixed crawl_permissions task to respect 'workspace_start_path' conf…
Browse files Browse the repository at this point in the history
…ig (#444)

The crawl_permissions task in assessment would not respect the config
value of workspace_start_path as it was not present in the 'from_dict'
classmethod. Added an extraction for the config.

Removed dbconnect from Contributing README as it is no longer needed.
  • Loading branch information
pritishpai authored Oct 12, 2023
1 parent 27ac85b commit af58f0e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ hatch env create

To install development dependencies, including testing and database connection packages, use the following command:
```shell
hatch run pip install -e '.[test,dbconnect]'
hatch run pip install -e '.[test]'
```

To ensure your integrated development environment (IDE) uses the newly created virtual environment, you can retrieve the Python path with this command:
Expand Down
1 change: 1 addition & 0 deletions src/databricks/labs/ucx/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@ def from_dict(cls, raw: dict):
log_level=raw.get("log_level", "INFO"),
database_to_catalog_mapping=raw.get("database_to_catalog_mapping", None),
default_catalog=raw.get("default_catalog", "main"),
workspace_start_path=raw.get("workspace_start_path", "/")
)

def to_workspace_client(self) -> WorkspaceClient:
Expand Down

0 comments on commit af58f0e

Please sign in to comment.