Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE]: Ignore whitelisted packages #1365

Closed
1 task done
Tracked by #1202
ericvergnaud opened this issue Apr 11, 2024 · 0 comments · Fixed by #1367
Closed
1 task done
Tracked by #1202

[FEATURE]: Ignore whitelisted packages #1365

ericvergnaud opened this issue Apr 11, 2024 · 0 comments · Fixed by #1367
Labels
enhancement New feature or request needs-triage

Comments

@ericvergnaud
Copy link
Contributor

ericvergnaud commented Apr 11, 2024 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Problem statement

When building a dependency graph, we should ignore built-in and pre-installed packages, since their migration would not be handled through a customer migration

Proposed Solution

Ignore dependencies from both a list of built-in python packages (such as 'os') and a runtime provided whitelist

Additional Context

Sub-ticket of #1202
@ericvergnaud ericvergnaud added enhancement New feature or request needs-triage labels Apr 11, 2024
This was referenced Apr 11, 2024
Closed
Merged
@nfx nfx closed this as completed in #1367 Apr 12, 2024
nfx pushed a commit that referenced this issue Apr 12, 2024
@ericvergnaud @JCZuurmond
Ignore whitelisted imports (#1367)
18f05b3 
## Changes
filter whitelisted python import dependencies 

### Linked issues
Related to #1202 
Resolves #1365

---------

Co-authored-by: Cor <jczuurmond@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request needs-triage
Projects
UCX (roadmap)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore whitelisted imports ericvergnaud/ucx
1 participant
@ericvergnaud